This repository has been archived by the owner on Jun 3, 2021. It is now read-only.
[Android] Fix Android Crash in PostTaskToMsgLoop #2830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kToMsgLoop` As `WeexCoreManager::Instance()->script_thread()` is initialized in `WeexCore::InitFramework`, `EagleBridge::WeexCoreHandler::PostTaskToMsgLoop` will crash if `WeexCore::InitFramework` is not invoked. Fix this problem by not supporting `EagleBridge::WeexCoreHandler::PostTaskToMsgLoop` anymore. ``` libweexcore.so (_ZN8WeexCore11EagleBridge15WeexCoreHandler17PostTaskToMsgLoopERKNSt6__ndk18functionIFvvEEE+13) ```
|
Darin726
reviewed
Aug 15, 2019
| WXBridgeManager.getInstance().post(new Runnable() { | ||
| @Override | ||
| public void run() { | ||
| nativeInvokeOnSuccess(sNativeCallback, script, bundleTypeStr); |
There was a problem hiding this comment.
这里需要判断一下 jsframework 是否初始化 ok 了
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Android] Fix Android Crash in
PostTaskToMsgLoopAs
WeexCoreManager::Instance()->script_thread()is initialized inWeexCore::InitFramework,EagleBridge::WeexCoreHandler::PostTaskToMsgLoopwill crash ifWeexCore::InitFrameworkis not invoked.Fix this problem by not supporting
EagleBridge::WeexCoreHandler::PostTaskToMsgLoopanymore.Stackstrace:
Brief Description of the PR
Checklist