This repository has been archived by the owner on Jun 3, 2021. It is now read-only.
[Android] Fix Android JNI Crash #2827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`jni_object()` in `ReportException()` could be nullptr if `InitFramework()` is not invoked. ``` JNI DETECTED ERROR IN APPLICATION: obj == null in call to CallVoidMethodV from int com.taobao.weex.bridge.WXBridge.nativeCreateInstanceContext(java.lang.String, java.lang.String, java.lang.String, com.taobao.weex.bridge.WXJSObject[]) ...... (_JNIEnv::CallVoidMethod(_jobject*, _jmethodID*, ...)+22) (WeexCore::WXBridge::ReportException(_JNIEnv*, char const*, char const*, char const*)+132) (WeexCore::AndroidSide::ReportException(char const*, char const*, char const*)+34) ...... (WeexCore::CoreSideInPlatform::CreateInstance(char const*, char const*, char const*, int, char const*, char const*, char const*, std::__ndk1::vector<InitFrameworkParams*, std::__ndk1::allocator<InitFrameworkParams*>>&, char const*)+820) at com.taobao.weex.bridge.WXBridge.nativeCreateInstanceContext(Native method) at com.taobao.weex.bridge.WXBridge.createInstanceContext(Taobao:233) at com.taobao.weex.bridge.WXBridgeManager.invokeCreateInstanceContext(Taobao:1981) at com.taobao.weex.bridge.WXBridgeManager.invokeCreateInstance(Taobao:1709) ```
message_loop() in PostTaskToMsgLoop() could be nullptr if InitFramework() is not invoked.
|
This reverts commit 04bc406
YorkShen
force-pushed
the
bugfix/android_jni_crash
branch
from
0ff50f7
to
6122f55
Compare
YorkShen
force-pushed
the
bugfix/android_jni_crash
branch
from
0f86d81
to
afa428e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Description of the PR
NPE in WXBridge::ReportException
jni_object()inReportException()could be nullptr ifInitFramework()is not invoked.Checklist