This repository has been archived by the owner on Jun 3, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[Android]support "wx" in animation and wxtext #2783
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YorkShen
suggested changes
Aug 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you are trying to add wx
support for animation and wxtext
, maybe you should consider GraphicActionAnimation as well.
android/sdk/src/main/java/com/taobao/weex/utils/WXViewUtils.java
Outdated
Show resolved
Hide resolved
android/sdk/src/main/java/com/taobao/weex/ui/animation/TransformParser.java
Outdated
Show resolved
Hide resolved
|
YorkShen
suggested changes
Aug 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{@link ClassName#MethodName(Parameter)
is a syntax supported by JavaDoc, you are missing#
WXLogUtils.e(String Tag, String Message);
. You are using the wrong tag. Actually,WXLogUtils.e(getStackTrace);
is enough.
YorkShen
suggested changes
Aug 29, 2019
android/sdk/src/main/java/com/taobao/weex/ui/action/GraphicActionAnimation.java
Outdated
Show resolved
Hide resolved
android/sdk/src/main/java/com/taobao/weex/ui/animation/TransformParser.java
Outdated
Show resolved
Hide resolved
YorkShen
approved these changes
Aug 30, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
YorkShen
added a commit
to YorkShen/incubator-weex
that referenced
this pull request
Sep 5, 2019
This is a bug in default value introduced by thttps://github.com/apache/pull/2783 ,which change some default value from 0 to Float.NAN . This commit will revert the behaviour change.
YorkShen
added a commit
that referenced
this pull request
Sep 5, 2019
This is a bug in default value introduced by thttps://github.com//pull/2783 ,which change some default value from 0 to Float.NAN . This commit will revert the behaviour change.
lucky-chen
added a commit
to lucky-chen/incubator-weex
that referenced
this pull request
Sep 19, 2019
This reverts commit 1f54d46.
Closed
lucky-chen
added a commit
to lucky-chen/incubator-weex
that referenced
this pull request
Sep 19, 2019
This reverts commit 1f54d46.
Merged
YorkShen
pushed a commit
that referenced
this pull request
Sep 20, 2019
YorkShen
pushed a commit
to YorkShen/incubator-weex
that referenced
this pull request
Sep 26, 2019
This reverts commit 1f54d46.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.