Skip to content
This repository has been archived by the owner on Jun 3, 2021. It is now read-only.

[Danger] Add some static check rules in dangerfile #2676

Merged
merged 14 commits into from
Jul 23, 2019

Conversation

wrmswindmill
Copy link
Contributor

@wrmswindmill wrmswindmill commented Jul 10, 2019

Brief Description of the PR

This PR add the following features:

  1. Check if PR is submitted to master branch,if not ,the Travis CI will build fail.
  2. Check if PR is binded with a milestone, if not, The Travis CI will output a warning message.
  3. Check if your PR description contains keywords Documentation and it's correponding http links.if not, The Travis CI will output a warning message.
  4. Check if your PR description contains keywords Demo and it's correponding http links.if not, The Travis CI will output a warning message.
  5. update the changelog check rule message

Checklist

@wrmswindmill wrmswindmill changed the title [Danger] Add Some Static Check Rule in Dangerfile [Danger] Add Some Static Check Rules in Dangerfile Jul 10, 2019
@wrmswindmill wrmswindmill changed the title [Danger] Add Some Static Check Rules in Dangerfile [Danger] Add some static check rules in dangerfile Jul 10, 2019
dangerfile.js Show resolved Hide resolved
dangerfile.js Show resolved Hide resolved
dangerfile.js Outdated Show resolved Hide resolved
dangerfile.js Outdated
const title = "No Changelog changes!"
const idea = "Can you add a Changelog?"+
"To do so,append your changes to the changelog.md "
warn(`${title} - <i>${idea}</i>`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: You can use markdown function in danger

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use markdown function is more readable. I have updated the code

dangerfile.js Outdated Show resolved Hide resolved
dangerfile.js Outdated Show resolved Hide resolved
.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
Copy link
Contributor

@YorkShen YorkShen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YorkShen
Copy link
Contributor

@YorkShen YorkShen merged commit 0898c8f into apache:master Jul 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants