This repository has been archived by the owner on Jun 3, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[Danger] Add some static check rules in dangerfile #2676
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ubator-weex into pr_static_check
YorkShen
reviewed
Jul 23, 2019
dangerfile.js
Outdated
const title = "No Changelog changes!" | ||
const idea = "Can you add a Changelog?"+ | ||
"To do so,append your changes to the changelog.md " | ||
warn(`${title} - <i>${idea}</i>`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: You can use markdown
function in danger
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use markdown
function is more readable. I have updated the code
YorkShen
suggested changes
Jul 23, 2019
YorkShen
approved these changes
Jul 23, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The check rules are described in https://github.com/apache/incubator-weex/blob/master/CONTRIBUTING.md#publish-your-change |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Description of the PR
This PR add the following features:
Documentation
and it's correponding http links.if not, The Travis CI will output a warning message.Demo
and it's correponding http links.if not, The Travis CI will output a warning message.Checklist