Skip to content
This repository has been archived by the owner on Jun 3, 2021. It is now read-only.

Commit

Permalink
[Android] Upgrade to android 28 (#2791)
Browse files Browse the repository at this point in the history
* Upgrade to android 28

* Update ChangeLog

* Update danger

* Update link
  • Loading branch information
YorkShen authored and Darin726 committed Aug 7, 2019
1 parent b641834 commit d469e47
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 24 deletions.
21 changes: 4 additions & 17 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,22 +1,9 @@
# Abstract
## Feature
* Support arm64 & ndk18 on Android platform.
* Android JSC Runtime refactor.
* Android & iOS multi-size screen & rotation support.
* Background JS thread on iOS.
* Log module on iOS and Android to support redirection
* Synchronous call of component methods.
### WeexCore
* Unified C++ log system of WeexCore.

## Main Bugfix
* Animation module crash on iOS.
* RTL layout crash on iOS.
* NSTimer not removed by WXTimerModule on iOS.
* Occasionally showing placeholder instead of main image on iOS.
* Animation end progress error on iOS.
* Some NPE issues on Android.
* Closing fd multiple times on Android IPC.
* box-shadow crash protection on Android.
* GPU texture size overflow protection on Android.
* Weexcore.so loading failure problem on Android.
### Android
* Upgrade targetsdk & compilesdk to 28

## Main Bugfix
4 changes: 2 additions & 2 deletions android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,9 @@ subprojects {
}
}
ext {
compileSdkVersion=26
compileSdkVersion=28
minSdkVersion=14
targetSdkVersion=26
targetSdkVersion=28
supportLibVersion="26.0.2"
fastjsonLibVersion="1.1.70.android"
//Default value for disableCov is false
Expand Down
8 changes: 4 additions & 4 deletions dangerfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -50,16 +50,16 @@ const includeChecklist = (index!=-1)
if(includeChecklist && !matchRegex(pr_body.substring(index),/documentation.*http/)){
const msg = "If you update the code, "+
"maybe you should update the documentation and add the documentation link in the PR description. \n" +
"here is the guide about how to contribute documentation:https://github.com/apache/incubator-weex/blob/master/CONTRIBUTING.md#contribute-code-or-document \n";
"here is the guide about how to contribute documentation: <a href='https://github.com/apache/incubator-weex/blob/master/CONTRIBUTING.md#contribute-code-or-document'>https://github.com/apache/incubator-weex/blob/master/CONTRIBUTING.md#contribute-code-or-document</a>";
warn(msg);
}

// check if pr contains a demo link
console.log("checkDemo");
if(!matchRegex(pr_body,/demo.*http/)){
const msg = "If your PR is about fixing a bug excluding crash the code,"+
"you should add the demo link in the PR description. \n "+
"here is a demo link:http://dotwe.org/vue?spm=a2c7j.-guide-contribute-contribute-code.0.0.3e93748cmxz3yt";
"you should add the demo link in the PR description. "+
"Demo link: <a href='http://dotwe.org/vue'>http://dotwe.org/vue</a>";
warn(msg);
}

Expand All @@ -70,7 +70,7 @@ if(!danger.github.pr.milestone){
}

// Make sure there are changelog entries
const hasChangelog = danger.git.modified_files.includes("changelog.md")
const hasChangelog = danger.git.modified_files.includes("CHANGELOG.md")
if (!hasChangelog) {
warn(`No Changelog changes! - <i>Can you add a Changelog? To do so,append your changes to the changelog.md</i>`);
}
Expand Down
2 changes: 1 addition & 1 deletion weex-playground
Submodule weex-playground updated 1 files
+2 −4 README.md

0 comments on commit d469e47

Please sign in to comment.