Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quarkus 3: Fix optaplanner snapshot check on 2.x #1840

Merged
merged 3 commits into from
Aug 22, 2023
Merged

Quarkus 3: Fix optaplanner snapshot check on 2.x #1840

merged 3 commits into from
Aug 22, 2023

Conversation

radtriste
Copy link
Contributor

@radtriste radtriste commented Aug 22, 2023 •
edited
Loading

@radtriste radtriste requested a review from lampajr August 22, 2023 13:10
lampajr
lampajr approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@lampajr lampajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not directly saving versionSplit as list? just suggestion otherwise looks good to me also in this way

.ci/jenkins/Jenkinsfile.optaplanner Outdated Show resolved Hide resolved
.ci/jenkins/Jenkinsfile.optaplanner Outdated Show resolved Hide resolved
@radtriste @lampajr
Apply suggestions from code review
3c2cb7a 
Co-authored-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
lampajr
lampajr approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@lampajr lampajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@radtriste radtriste changed the title Fix optaplanner snapshot check on 2.x Quarkus 3: Fix optaplanner snapshot check on 2.x Aug 22, 2023
@radtriste radtriste merged commit 3f9153b into main Aug 22, 2023
1 check passed
@radtriste radtriste deleted the fix-optaplanner-check-on-2_x branch August 22, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lampajr lampajr lampajr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radtriste @lampajr