NO ISSUE: Migrate impact analysis to JUnit5

[pibizza]

• migrated impact analysis to JUnit5
• some good use of paramerized tests.

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:

• for pull request and downstream checks

  • Push a new commit to the PR. An empty commit would be enough.

• for a full downstream build

  • for github actions job: add the label run_fdb

• for Jenkins PR check only

  • If you are an ASF committer for KIE podling, login to Jenkins (https://ci-builds.apache.org/job/KIE/job/drools/), go to the specific PR job, and click on Build Now button.

[tkobayas]

Thanks!

[gitgabrio]

HI @pibizza
Do you think it would be possible to start introducing the enforcer also here ? My idea is that while progressively migrate the assertions, it would be usefull to avoid their re-introduction in the "sanitized" module: wdyt ?

[pibizza]

@gitgabrio I would probably try to add it as a global check, once we have migrated everything.

[gitgabrio]

Yup. My concern is that, since this will take some time (not sure, TBH), while you fix other modules, the ones already fixed could be accidentally "broken" again (as already happened, at least inside DMN). Anyway, your call...