[incubator-kie-issues#1411] Ban usage of Junit assertions inside DMN

[gitgabrio]

Fixes apache/incubator-kie-issues#1461

This PR:

1. remove usage of Junit assertions
2. enforce/ban their reintroduction

@bncriju FYI

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:

• for pull request and downstream checks

  • Push a new commit to the PR. An empty commit would be enough.

• for a full downstream build

  • for github actions job: add the label run_fdb

• for Jenkins PR check only

  • If you are an ASF committer for KIE podling, login to Jenkins (https://ci-builds.apache.org/job/KIE/job/drools/), go to the specific PR job, and click on Build Now button.

[gitgabrio]

Kogito Downstream / kogito-apps (ubuntu-latest / Java-17 / Maven-3.9.6) (pull_request) failure unrelated

2024-09-04T07:01:18.2087606Z [ERROR] Tests run: 4, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 60.50 s <<< FAILURE! -- in org.kie.kogito.index.service.graphql.MongoWebSocketSubscriptionIT
2024-09-04T07:01:18.2090158Z [ERROR] org.kie.kogito.index.service.graphql.MongoWebSocketSubscriptionIT.testDomainSubscription -- Time elapsed: 60.12 s <<< ERROR!
2024-09-04T07:01:18.2091630Z java.util.concurrent.TimeoutException
2024-09-04T07:01:18.2092660Z 	at java.base/java.util.concurrent.CompletableFuture.timedGet(CompletableFuture.java:1960)
2024-09-04T07:01:18.2094012Z 	at java.base/java.util.concurrent.CompletableFuture.get(CompletableFuture.java:2095)
2024-09-04T07:01:18.2095945Z 	at org.kie.kogito.index.service.graphql.AbstractWebSocketSubscriptionIT.assertDomainSubscription(AbstractWebSocketSubscriptionIT.java:159)
2024-09-04T07:01:18.2207717Z 	at org.kie.kogito.index.service.graphql.AbstractWebSocketSubscriptionIT.testDomainSubscription(AbstractWebSocketSubscriptionIT.java:144)
2024-09-04T07:01:18.2209585Z 	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
2024-09-04T07:01:18.2210869Z 	at io.quarkus.test.junit.QuarkusTestExtension.runExtensionMethod(QuarkusTestExtension.java:1013)
2024-09-04T07:01:18.2212464Z 	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestMethod(QuarkusTestExtension.java:827)
2024-09-04T07:01:18.2213662Z 	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
2024-09-04T07:01:18.2214941Z 	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

[pibizza]

I have suggested a number of small changes to make better use of assertj assertions.

I have other points for stream assertions but I think we can address them in a separate PR.

Once the suggestions are reviewed and eventually merged you can proceed.. Thank you.

[pibizza]

LGTM. Thank you.