Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced testSalienceIntegerAndLoadOrder for better memory management and type safety #6042

Merged

Conversation

Rashmesh
Copy link
Contributor

NOTE!: Double-check the target branch for this PR.

Ports: If a forward-port or a backport is needed, paste the forward port PR here
NA

Issue: (please edit the GitHub Issues link if it exists)
NA

Referenced Pull Requests:
NA

How to replicate CI configuration locally? Performed the following: ```bash git clone https://github.com/kiegroup/github-action-build-chain.git cd github-action-build-chain

npm install

Create a configuration `build-chain-config.yml`:
```yaml
repositories:
  - name: kiegroup/drools
    branch: main

Run:

node dist/index.js --flow-type pr --config ./build-chain-config.yml

Tested it locally also by running the drools-test-coverage

@tkobayas
Copy link
Contributor

tkobayas commented Aug 21, 2024

Hi @Rashmesh , thank you for the PR.

I see that this PR does:

  • Call ksession.dispose()
  • Change List to List<String>

Both are totally valid and better coding, but I wonder if we will take this kind of PR per test method.

Probably you are aware that many test cases in this project have similar room to improve. It would be great to improve them at once e.g. using a shell script or OpenRewrite (https://docs.openrewrite.org/). If manual intervention is required, hmm, at least PR per test class would be nice? I'm not asking you to do that now. Just thinking out loud...

Any thoughts? > @pibizza @mariofusco

@tkobayas
Copy link
Contributor

One more note: Basically, we file an "issue" with description and put a link to the issue in a PR.

for example)
Issue: #6016
PR: #6024

Copy link
Contributor

@pibizza pibizza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mariofusco mariofusco merged commit 4b09cca into apache:main Aug 21, 2024
10 checks passed
rgdoliveira pushed a commit to rgdoliveira/drools that referenced this pull request Aug 26, 2024
… and type safety (apache#6042)

Co-authored-by: Rashmesh Radhakrishnan <rashmeshradhakrishnan@Rashmeshs-Mac-Studio.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants