Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kie-issues#653] Don't use System.out and logger debug mode in test output in traits #5565

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

baldimir
Copy link
Contributor

Fixes apache/incubator-kie-issues#653

  • Changes logger debug mode in tests in the whole repository
  • Replaces or removes the use of System.out or System.err in drools-traits tests. When an occurence is replaced, it is replaced with logger.

@jstastny-cz this should fix the huge logs you reported from drools-traits in the CI logs.

@jstastny-cz
Copy link
Contributor

I will review the PR check logs in the morning, but seems promising ;-) Thanks.

Copy link
Contributor

@jstastny-cz jstastny-cz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good.

Just for the record I see some seemingly sysout prints still:
[INFO] Running org.drools.decisiontable.SpreadsheetCompilerUnitTest
[INFO] Running org.drools.model.codegen.execmodel.AccumulateTest
[INFO] Running org.drools.model.codegen.execmodel.CepTest
[INFO] Running org.drools.model.codegen.execmodel.CompilationFailuresTest
[INFO] Running org.drools.model.codegen.execmodel.FromTest
(and generally codegen tests seem to be quite verbose)

[INFO] Running org.drools.mvel.integrationtests.concurrency.ConcurrentInsertionsToSubnetworksTest
[INFO] Running org.drools.mvel.integrationtests.QueryInRHSCepTest - this one has exception stack trace printed

etc.

But the drools-traits tests seem alright, which was the scope tackled in this one.

@baldimir baldimir merged commit 75438b3 into apache:main Oct 27, 2023
7 of 9 checks passed
rgdoliveira pushed a commit to kiegroup/drools that referenced this pull request Dec 13, 2023
@baldimir baldimir deleted the traits-tests-output branch February 14, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not use logger level debug or System.out.println in tests in Drools repository
3 participants