Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DROOLS-6834] remove drl prefix from drools quarkus extension + create drools-drl parent module #5564

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

mariofusco
Copy link
Contributor

@mariofusco mariofusco commented Oct 24, 2023

Copy link
Contributor

@lucamolteni lucamolteni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was -drl for btw?

@mariofusco
Copy link
Contributor Author

mariofusco commented Oct 25, 2023

What was -drl for btw?

In the Quarkus extension? Something that we added to (mistakenly) underline that the extension was only for drl and the biggest part of the capabilities were in kogito.

@mariofusco mariofusco merged commit 4d085f9 into apache:main Oct 25, 2023
7 of 9 checks passed
@mariofusco mariofusco deleted the d6834 branch October 25, 2023 10:53
@jstastny-cz
Copy link
Contributor

Looking at the jenkins PR checks results - this failure is expected?

org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal on project kogito-quarkus-common-deployment: Could not resolve dependencies for project org.kie.kogito:kogito-quarkus-common-deployment:jar:2.0.0-SNAPSHOT: Could not find artifact org.drools:drools-drl-quarkus-util-deployment:jar:8.45.0-SNAPSHOT in apache-public-repository-group

@mariofusco
Copy link
Contributor Author

@jstastny-cz Do you mean the failure on jenkins? I was actually only looking at the github actions. That failure is caused by the fact that jenkins run without the 2nd PR the one on kogito-runtimes apache/incubator-kie-kogito-runtimes#3261 which fixes the problem.

@jstastny-cz
Copy link
Contributor

Ah, ok, a retrigger of the failed jenkins check once the 2nd PR was available would resolve, the new run would pick the change up. Thanks for explanation @mariofusco

rgdoliveira pushed a commit to kiegroup/drools that referenced this pull request Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants