Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kie-issues#628] Update repositories and other small changes to Apache #5553

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

baldimir
Copy link
Contributor

This PR removes JBoss Nexus from the repositories and replaces it with Apache Nexus. Then it fixes some other places with old references, like kiegroup etc.

@kie-ci3
Copy link

kie-ci3 commented Oct 12, 2023

PR job #1 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://github.com/raw/${AUTHOR:apache}/incubator-kie-drools/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-drools -u #5553 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/drools/job/main/job/pullrequest_jobs/job/drools-pr/job/PR-5553/1/display/redirect

Test results:

  • PASSED: 21722
  • FAILED: 5

Those are the test failures:

org.drools.traits.compiler.integrationtests.TraitTypeGenerationTest.testNeeds Exception executing consequence for rule "Main" in org.drools.abductive.test: java.lang.NullPointerException
org.drools.traits.compiler.integrationtests.TraitTypeGenerationTest.testMvelJittingWithTraitProxies Exception executing consequence for rule "In1" in org.drools.test: java.lang.NullPointerException
org.drools.traits.compiler.integrationtests.TraitTypeGenerationTest.testIsAWith2KContainers Exception executing consequence for rule "create student" in defaultpkg: java.lang.NullPointerException
org.drools.traits.compiler.integrationtests.TraitTypeGenerationTest.testWithDeclaredTypeAndTraitInDifferentPackages Exception executing consequence for rule "R" in org.pkg3: java.lang.NullPointerException
org.drools.traits.compiler.integrationtests.TraitTypeGenerationTest.testWithBeanAndTraitInDifferentPackages Exception executing consequence for rule "R" in org.drools.test: java.lang.NullPointerException

Copy link
Contributor

@jstastny-cz jstastny-cz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 minor comments about mailing list info, looks good.

<system>jira</system>
<url>https://issues.jboss.org/browse/DROOLS</url>
<system>GitHub Issues</system>
<url>https://github.com/apache/incubator-kie-issues/issues</url>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mailing lists section below lacks the newly added entry.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

<system>jira</system>
<url>https://issues.jboss.org/browse/DROOLS</url>
<system>GitHub Issues</system>
<url>https://github.com/apache/incubator-kie-issues/issues</url>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mailing lists section below lacks the newly added entry.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@mariofusco mariofusco merged commit 0f1ac20 into apache:main Oct 16, 2023
1 of 9 checks passed
rgdoliveira pushed a commit to kiegroup/drools that referenced this pull request Dec 13, 2023
apache#5553)

* Update repositories and other small changes to Apache

* Add missing mailing list configuration.
@baldimir baldimir deleted the apache-nexus-configuration branch February 14, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants