[kie-issues-249] Data Index Events changes for allowing historical data #5529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 19, 2023
porcelli
previously requested changes
Sep 20, 2023
elguardian
force-pushed
the
kie-issues-249
branch
from
6a4efec
to
9c0584d
Compare
mariofusco
previously requested changes
Sep 25, 2023
|
@mariofusco I hear you, and it makes sense. however if you check all events related to process are already here, so I'd argue that we could discuss in a different thread and eventually PR moving the process related content from drools to kogito. |
|
@mariofusco unfortunately is how the design works. the idea is to strip the jbpm engine in the medium term. so for now we cannot change the dependencies just to acommodate this. it is out of the scope of the jira. |
elguardian
dismissed
mariofusco’s stale review
revisit dependencies is out of the scope of the jira.
|
@elguardian @porcelli That's fine, for now it's ok for me. If possible please open another ticket to better isolate this stuff in a second step. |
mariofusco
approved these changes
Sep 28, 2023
elguardian
force-pushed
the
kie-issues-249
branch
2 times, most recently
from
248b893
to
ac8d7fa
Compare
elguardian
force-pushed
the
kie-issues-249
branch
from
ac8d7fa
to
a5a2f3d
Compare
porcelli
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: apache/incubator-kie-issues#249