-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pd-store): intro Useless
annotation & refactor and mark the failed tests in hg-pd-test
#2480
Merged
Merged
Changes from 2 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
66122a6
fix NPE
VGalaxies ad5b5f2
adapt some tests
VGalaxies d55f080
intro useless annotation
VGalaxies a689e3a
Revert "adapt some tests"
VGalaxies 48eeaca
mark some classes useless and rearrange package
VGalaxies b7bb946
Update hugegraph-pd/hg-pd-common/src/main/java/org/apache/hugegraph/p…
VGalaxies b16d510
rearrange test package
VGalaxies dc01e13
rearrange test package
VGalaxies 2ce1469
fix HgKVStoreImplTest
VGalaxies 8a64eb4
mark tests in grpc package is useless
VGalaxies 32e93ff
add comment for PartitionCacheTest
VGalaxies 4eb5d04
add comment for PartitionServiceTest
VGalaxies dd644fe
refactor pd core tests
VGalaxies 87bff7c
Update hugegraph-pd/hg-pd-test/src/main/java/org/apache/hugegraph/pd/…
VGalaxies 9f79e9c
ignore some core tests
VGalaxies 5cd0d02
ignore some tests
VGalaxies afe9906
rearrange pd CI yml
VGalaxies 04c8eff
add value for Useless annotation
VGalaxies File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 changes: 0 additions & 31 deletions
31
hugegraph-pd/hg-pd-test/src/main/java/org/apache/hugegraph/pd/UnitTestBase.java
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if a test is hard to ensure the meaning or currently we can't run it well, we could add
@Ignore
for it rather than comment@Test
(sothat we could search ignore in future)
maybe we could also add a annotation
@useless
for other useless classes/method?