fix(pd-store): intro Useless annotation & refactor and mark the failed tests in hg-pd-test
#2480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## pd-store #2480 +/- ##
===========================================
Coverage ? 56.85%
Complexity ? 2149
===========================================
Files ? 718
Lines ? 58323
Branches ? 7490
===========================================
Hits ? 33157
Misses ? 21917
Partials ? 3249 ☔ View full report in Codecov by Sentry. |
imbajin
reviewed
Mar 16, 2024
| @@ -420,7 +425,7 @@ public void onPartitionRemoved(Metapb.Partition partition) { | |||
|
|
|||
| } | |||
|
|
|||
| // @Test | |||
There was a problem hiding this comment.
if a test is hard to ensure the meaning or currently we can't run it well, we could add @Ignore for it rather than comment @Test (so
that we could search ignore in future)
maybe we could also add a annotation @useless for other useless classes/method?
![github-actions[bot]](https://github.com/avatars/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has totally checked 1676 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 1326 | 1 | 349 | 0 |
Click to see the invalid file list
- hugegraph-pd/hg-pd-common/src/main/java/org/apache/hugegraph/pd/common/Useless.java
hugegraph-pd/hg-pd-common/src/main/java/org/apache/hugegraph/pd/common/Useless.java
Show resolved
Hide resolved
VGalaxies
changed the title
Useless annotation & fix pd service tests failure
…d/common/Useless.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
VGalaxies
changed the title
Useless annotation & fix pd service tests failureUseless annotation & fix pd tests failure
There was a problem hiding this comment.
license-eye has totally checked 1673 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 1323 | 1 | 349 | 0 |
Click to see the invalid file list
- hugegraph-pd/hg-pd-test/src/main/java/org/apache/hugegraph/pd/rest/PDRestSuiteTest.java
hugegraph-pd/hg-pd-test/src/main/java/org/apache/hugegraph/pd/rest/PDRestSuiteTest.java
Show resolved
Hide resolved
…rest/PDRestSuiteTest.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
dosubot
bot
added
the
size:XXL
dosubot
bot
added
bug
imbajin
reviewed
Mar 16, 2024
hugegraph-pd/hg-pd-common/src/main/java/org/apache/hugegraph/pd/common/Useless.java
Outdated
Show resolved
Hide resolved
9 tasks
VGalaxies
changed the title
Useless annotation & fix pd tests failureUseless annotation & mark the failed tests in pd-test
VGalaxies
changed the title
Useless annotation & mark the failed tests in pd-testUseless annotation & mark the failed tests in hg-pd-test
VGalaxies
changed the title
Useless annotation & mark the failed tests in hg-pd-testUseless annotation & refactor and mark the failed tests in hg-pd-test
imbajin
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
subtask of #2265
Some unused classes have been annotated with
@Useless, while some temporarily failing tests have been annotated with@Ignore(some tests'@Testannotations have been commented out).