-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pd-store): intro Useless
annotation & refactor and mark the failed tests in hg-pd-test
#2480
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## pd-store #2480 +/- ##
===========================================
Coverage ? 56.85%
Complexity ? 2149
===========================================
Files ? 718
Lines ? 58323
Branches ? 7490
===========================================
Hits ? 33157
Misses ? 21917
Partials ? 3249 ☔ View full report in Codecov by Sentry. |
@@ -420,7 +425,7 @@ public void onPartitionRemoved(Metapb.Partition partition) { | |||
|
|||
} | |||
|
|||
// @Test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if a test is hard to ensure the meaning or currently we can't run it well, we could add @Ignore
for it rather than comment @Test
(so
that we could search ignore in future)
maybe we could also add a annotation @useless
for other useless classes/method?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has totally checked 1676 files.
Valid | Invalid | Ignored | Fixed |
---|---|---|---|
1326 | 1 | 349 | 0 |
Click to see the invalid file list
- hugegraph-pd/hg-pd-common/src/main/java/org/apache/hugegraph/pd/common/Useless.java
hugegraph-pd/hg-pd-common/src/main/java/org/apache/hugegraph/pd/common/Useless.java
Show resolved
Hide resolved
Useless
annotation & fix pd service tests failure
…d/common/Useless.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Useless
annotation & fix pd service tests failureUseless
annotation & fix pd tests failure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has totally checked 1673 files.
Valid | Invalid | Ignored | Fixed |
---|---|---|---|
1323 | 1 | 349 | 0 |
Click to see the invalid file list
- hugegraph-pd/hg-pd-test/src/main/java/org/apache/hugegraph/pd/rest/PDRestSuiteTest.java
hugegraph-pd/hg-pd-test/src/main/java/org/apache/hugegraph/pd/rest/PDRestSuiteTest.java
Show resolved
Hide resolved
…rest/PDRestSuiteTest.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
hugegraph-pd/hg-pd-common/src/main/java/org/apache/hugegraph/pd/common/Useless.java
Outdated
Show resolved
Hide resolved
Useless
annotation & fix pd tests failureUseless
annotation & mark the failed tests in pd-test
Useless
annotation & mark the failed tests in pd-testUseless
annotation & mark the failed tests in hg-pd-test
Useless
annotation & mark the failed tests in hg-pd-test
Useless
annotation & refactor and mark the failed tests in hg-pd-test
subtask of #2265
Some unused classes have been annotated with
@Useless
, while some temporarily failing tests have been annotated with@Ignore
(some tests'@Test
annotations have been commented out).