Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove body limit for influxql request #783

Merged
merged 1 commit into from
Mar 28, 2023
Merged

fix: remove body limit for influxql request #783

merged 1 commit into from
Mar 28, 2023

Conversation

jiacai2050
Copy link
Contributor

@jiacai2050 jiacai2050 commented Mar 28, 2023 •
edited
Loading

Which issue does this PR close?

Closes #

Rationale for this change

Current influxql handler can't process get request correctly

curl -i -XPOST "http://localhost:5440/influxdb/v1/write" --data-binary '
fff,tag1=t1,tag2=t2 field1=90,field2=100 1679994647000
fff,tag1=t1,tag2=t2 field1=91,field2=101 1679994648000
fff,tag1=t11,tag2=t22 field1=90,field2=100 1679994647000
fff,tag1=t11,tag2=t22 field1=91,field2=101 1679994648000
'

curl  -G 'http://localhost:5440/influxdb/v1/query' --data-urlencode 'q=select * from fff'

Command above will throw Rejection(LengthRequired) error when query.

What changes are included in this PR?

  • Remove body limit for influxql handler

Are there any user-facing changes?

No

How does this change test

CI

Rachelint
Rachelint approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@Rachelint Rachelint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rachelint Rachelint added this pull request to the merge queue Mar 28, 2023
Merged via the queue into apache:main with commit 2445bb1 Mar 28, 2023
@jiacai2050 jiacai2050 mentioned this pull request Mar 28, 2023
Merged
jiacai2050 added a commit that referenced this pull request Mar 28, 2023
@jiacai2050
fix: remove body limit for influxql request (#783)
a6ecdc8
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
@jiacai2050
fix: remove body limit for influxql request (apache#783)
c4b5f3a
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rachelint Rachelint Rachelint approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiacai2050 @Rachelint