Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix varbinary type error #653

Merged
merged 2 commits into from
Feb 17, 2023
Merged

fix: fix varbinary type error #653

merged 2 commits into from
Feb 17, 2023

Conversation

ZuLiangWang
Copy link
Contributor

Which issue does this PR close?

Closes #637

Rationale for this change

Fix the problem of table creation failure mentioned in issue.

What changes are included in this PR?

  • Fix SqlDataType convert error.
  • Add create table test with VARBINARY type.

Are there any user-facing changes?

User could create table with VARBINARY type normally.

How does this change test

Pass integration tests.

@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2023

Codecov Report

Merging #653 (aa69cac) into main (9e7733b) will increase coverage by 0.08%.
The diff coverage is 26.56%.

❗ Current head aa69cac differs from pull request most recent head 9ccdcf8. Consider uploading reports for the commit 9ccdcf8 to get more accurate results

@@            Coverage Diff             @@
##             main     #653      +/-   ##
==========================================
+ Coverage   66.84%   66.92%   +0.08%     
==========================================
  Files         283      283              
  Lines       44006    43962      -44     
==========================================
+ Hits        29414    29422       +8     
+ Misses      14592    14540      -52     
Impacted Files Coverage Δ
analytic_engine/src/compaction/scheduler.rs 68.09% <ø> (ø)
analytic_engine/src/instance/flush_compaction.rs 66.41% <0.00%> (-0.22%) ⬇️
analytic_engine/src/sampler.rs 99.33% <0.00%> (ø)
analytic_engine/src/sst/file.rs 77.17% <ø> (+1.00%) ⬆️
analytic_engine/src/table_options.rs 64.12% <ø> (ø)
catalog_impls/src/table_based.rs 83.58% <0.00%> (ø)
catalog_impls/src/volatile.rs 0.00% <0.00%> (ø)
cluster/src/config.rs 77.77% <ø> (ø)
cluster/src/shard_tables_cache.rs 0.00% <0.00%> (ø)
common_types/src/datum.rs 50.69% <0.00%> (ø)
... and 110 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShiKaiWi ShiKaiWi added this pull request to the merge queue Feb 17, 2023
Merged via the queue into apache:main with commit 7b6ca9a Feb 17, 2023
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
* fix varbinary type error

* add all type test
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unsupported SQL data type, err:Unsupported SQL data type, type:VARBINARY.
4 participants