fix: wrong primary key when define tsid and timestamp key as primary key #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiacai2050
reviewed
Dec 7, 2022
ShiKaiWi
changed the title
chunshao90
pushed a commit
to chunshao90/ceresdb
that referenced
this pull request
May 15, 2023
…key (apache#453) * fix: wrong primary when define tsid and tiemstamp key as primary key * chore: add test for define primary with tsid * chore: fix harness test * refactor: add some comments * fix: wrong order of the primary key columns * chore: replace BTreeMap with HashMap for columns_by_names
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #
Rationale for this change
After #340 merged, it can't define (tsid, timestamp_key_name) as primary key. And this pr will fix this problem.
What changes are included in this PR?
Are there any user-facing changes?
The tsid column will be the last column in the schema after this pr, compared with that tsid column just follows the timestamp key column.
How does this change test
New sql test in the harness.