Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing filter index over the primary keys #1456

Merged
merged 1 commit into from
Jan 23, 2024
Merged

fix: missing filter index over the primary keys #1456

merged 1 commit into from
Jan 23, 2024

Conversation

ShiKaiWi
Copy link
Member

Rationale

Current filter index won't be created over the primary key columns, and it leads to unexpected low prune rate in some cases.

Detailed Changes

  • Separate the filter module as a sub-module of the meta_data
  • Create filter index over the primary key columns except the tsid and timestamp column.

Test Plan

Should pass the CI.

jiacai2050
jiacai2050 approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 merged commit 106197d into apache:main Jan 23, 2024
6 checks passed
@ShiKaiWi ShiKaiWi deleted the fix-primary-key-index branch January 23, 2024 07:52
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiacai2050 jiacai2050 jiacai2050 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShiKaiWi @jiacai2050