-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDFS-17584. DistributedFileSystem verifyChecksum should be configurable #6947
base: trunk
Are you sure you want to change the base?
Conversation
@slfan1989 @Hexiaoqiao Could you take a look? Thanks. |
💔 -1 overall
This message was automatically generated. |
LGTM. |
@@ -6606,4 +6606,11 @@ | |||
Enables observer reads for clients. This should only be enabled when clients are using routers. | |||
</description> | |||
</property> | |||
<property> | |||
<name>dfs.client.verify.checksum.enabled</name> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @2005hithlj , Thanks for your works. There is already one interface to enable verify checksum, it seems more flexible IMO, so why we need to config it? Thanks again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hexiaoqiao Thanks for your review. Does the "interface" here refer to DistributedFileSystem.setVerifyChecksum?
For example, in some POC scenarios where the POC use cases are already fixed, which may be SQLs or other forms, if we want to turn off the checksum to observe the effect, it would be a better choice to do so through configuration items.
Description of PR
JIRA: https://issues.apache.org/jira/browse/HDFS-17584
How was this patch tested?
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?