-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YARN-11704. No need to apply extra 'AND' placement constraint for non tags in PlacementConstraintManager.getMultilevelConstraint #6940
Open
zuston
wants to merge
1
commit into
apache:trunk
Choose a base branch
from
zuston:yarn-11704
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cheduling request
PTAL @slfan1989 This is a small improvement for placement constraint mechanism |
💔 -1 overall
This message was automatically generated. |
slfan1989
reviewed
Jul 15, 2024
mergedConstraint = (And) constraint.getConstraintExpr(); | ||
Assert.assertEquals(1, mergedConstraint.getChildren().size()); | ||
Assert.assertEquals(c1, mergedConstraint.getChildren().get(0).build()); | ||
Assert.assertTrue(constraint.getConstraintExpr().getClass() == c1.getConstraintExpr().getClass()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
After applying the placement constraint allocator in our internal cluster, I found some hotpoint that will effect the scheduling performance as the allocation time metric value increase a lot.
After dumping the flamegraph, the hotpoint is that the
SingleConstraintAppPlacementAllocator.checkCardinalityAndPending
, this should be optimized by like cache or other ways. But the unnecessary nested AND placement constraint may be a small improvement for this case.How was this patch tested?
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?