-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-19223. Continue running the pipeline even if stages fail #6937
base: trunk
Are you sure you want to change the base?
Conversation
@steveloughran @Hexiaoqiao @ayushtkn do you guys think this makes sense? |
🎊 +1 overall
This message was automatically generated. |
I like the -1 here. emphasises that tests are not an option and that leaving out tests is a special case which needs active intervention |
+1 I agree with Steve's opinion that we expect unit tests to be added when submitting code. However, for tasks like upgrading jar dependencies or changing shell scripts, it should be confirmed by the reviewer whether unit tests are necessary. |
@steveloughran @slfan1989 but, explicitly -1 breaks the pipeline (see example I provided), we know nothing about other stages, do you have other suggestions? |
|
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
@@ -261,11 +261,13 @@ | |||
"debian:10": "openjdk-11-jdk", | |||
"ubuntu:focal": [ | |||
"openjdk-8-jdk", | |||
"openjdk-11-jdk" | |||
"openjdk-11-jdk", | |||
"openjdk-17-jdk" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to touch something to trigger "platform changes" to verify this PR.
@steveloughran I adopted this suggestion, how about now? |
also cc @adoroszlai @ayushtkn |
was this failure the outcome desired? logs imply it, but we don't get the yetus report |
@steveloughran what do you mean "yetus report"? the GitHub comments are there as expected. |
Description of PR
Yetus votes -1 if the PR does not touch tests, which causes the pipeline fail fast and have no chance to run the rest stages. This PR changes the strategy to always run the whole pipeline and report failure at the end.
How was this patch tested?
Before
After
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?