HADOOP-19223. Continue running the pipeline even if stages fail

[pan3793]

Description of PR

Yetus votes -1 if the PR does not touch tests, which causes the pipeline fail fast and have no chance to run the rest stages. This PR changes the strategy to always run the whole pipeline and report failure at the end.

How was this patch tested?

Before

After

For code changes:

• Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
• Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
• If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
• If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

[pan3793]

@steveloughran @Hexiaoqiao @ayushtkn do you guys think this makes sense?

[hadoop-yetus]

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 21s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-0 ⚠️	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 12s		Maven dependency ordering for branch
+1 💚	mvninstall	21m 56s		trunk passed
+1 💚	mvnsite	0m 0s		trunk passed
+1 💚	shadedclient	20m 35s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 24s		Maven dependency ordering for patch
+1 💚	mvninstall	0m 0s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	0m 0s		the patch passed
+1 💚	shellcheck	0m 0s		No new issues.
+1 💚	shadedclient	23m 24s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	asflicense	0m 24s		The patch does not generate ASF License warnings.
		82m 49s

Subsystem	Report/Notes
Docker	ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6937/1/artifact/out/Dockerfile
GITHUB PR	#6937
Optional Tests	dupname asflicense mvnsite unit codespell detsecrets shellcheck shelldocs
uname	Linux df038015ae9e 5.15.0-106-generic #116-Ubuntu SMP Wed Apr 17 09:17:56 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / 87fa705
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6937/1/testReport/
Max. process+thread count	553 (vs. ulimit of 5500)
modules	C: U:
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6937/1/console
versions	git=2.25.1 maven=3.6.3 shellcheck=0.7.0
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

[steveloughran]

I like the -1 here. emphasises that tests are not an option and that leaving out tests is a special case which needs active intervention

[slfan1989]

I like the -1 here. emphasises that tests are not an option and that leaving out tests is a special case which needs active intervention

+1

I agree with Steve's opinion that we expect unit tests to be added when submitting code. However, for tasks like upgrading jar dependencies or changing shell scripts, it should be confirmed by the reviewer whether unit tests are necessary.

[pan3793]

@steveloughran @slfan1989 but, explicitly -1 breaks the pipeline (see example I provided), we know nothing about other stages, do you have other suggestions?

[steveloughran]

1. which other actions in the pipeline are breaking
2. could there be a way to postpone the failure until later, while still failing the build?

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 18s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 11s		Maven dependency ordering for branch
+1 💚	mvninstall	19m 44s		trunk passed
+1 💚	mvnsite	0m 0s		trunk passed
+1 💚	shadedclient	19m 41s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 23s		Maven dependency ordering for patch
+1 💚	mvninstall	0m 0s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	0m 0s		the patch passed
+1 💚	shellcheck	0m 0s		No new issues.
+1 💚	shadedclient	19m 23s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	asflicense	0m 26s		The patch does not generate ASF License warnings.
		75m 17s

Subsystem	Report/Notes
Docker	ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6937/2/artifact/out/Dockerfile
GITHUB PR	#6937
Optional Tests	dupname asflicense codespell detsecrets shellcheck shelldocs mvnsite unit
uname	Linux be2e04c80ceb 5.15.0-106-generic #116-Ubuntu SMP Wed Apr 17 09:17:56 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / 7a03bb3
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6937/2/testReport/
Max. process+thread count	555 (vs. ulimit of 5500)
modules	C: U:
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6937/2/console
versions	git=2.25.1 maven=3.6.3 shellcheck=0.7.0
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	18m 19s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	shellcheck	0m 0s		Shellcheck was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+0 🆗	jsonlint	0m 0s		jsonlint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 8s		Maven dependency ordering for branch
+1 💚	mvninstall	19m 58s		trunk passed
+1 💚	mvnsite	0m 0s		trunk passed
+1 💚	shadedclient	52m 56s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 21s		Maven dependency ordering for patch
+1 💚	mvninstall	0m 0s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	0m 0s		the patch passed
+1 💚	shadedclient	18m 24s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	asflicense	0m 25s		The patch does not generate ASF License warnings.
		91m 23s

Subsystem	Report/Notes
Docker	ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6937/3/artifact/out/Dockerfile
GITHUB PR	#6937
Optional Tests	dupname asflicense codespell detsecrets shellcheck shelldocs jsonlint mvnsite unit
uname	Linux 2b44f15594da 5.15.0-106-generic #116-Ubuntu SMP Wed Apr 17 09:17:56 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / 749a358
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6937/3/testReport/
Max. process+thread count	558 (vs. ulimit of 5500)
modules	C: U:
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6937/3/console
versions	git=2.9.5 maven=3.6.3
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	11m 24s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	shellcheck	0m 0s		Shellcheck was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+0 🆗	jsonlint	0m 0s		jsonlint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+0 🆗	mvndep	0m 30s		Maven dependency ordering for branch
+1 💚	mvninstall	17m 35s		trunk passed
+1 💚	mvnsite	0m 0s		trunk passed
+1 💚	shadedclient	36m 59s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 30s		Maven dependency ordering for patch
+1 💚	mvninstall	0m 0s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	0m 0s		the patch passed
+1 💚	shadedclient	18m 23s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	asflicense	0m 29s		The patch does not generate ASF License warnings.
		68m 47s

Subsystem	Report/Notes
Docker	ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6937/3/artifact/out/Dockerfile
GITHUB PR	#6937
Optional Tests	dupname asflicense codespell detsecrets shellcheck shelldocs jsonlint mvnsite unit
uname	Linux 2b3535941438 5.15.0-106-generic #116-Ubuntu SMP Wed Apr 17 09:17:56 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / 749a358
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6937/3/testReport/
Max. process+thread count	555 (vs. ulimit of 5500)
modules	C: U:
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6937/3/console
versions	git=2.27.0 maven=3.6.3
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 37s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	shellcheck	0m 0s		Shellcheck was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+0 🆗	jsonlint	0m 0s		jsonlint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+0 🆗	mvndep	0m 31s		Maven dependency ordering for branch
+1 💚	mvninstall	17m 17s		trunk passed
+1 💚	mvnsite	0m 0s		trunk passed
+1 💚	shadedclient	36m 27s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 31s		Maven dependency ordering for patch
+1 💚	mvninstall	0m 0s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	0m 0s		the patch passed
+1 💚	shadedclient	18m 21s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	asflicense	0m 27s		The patch does not generate ASF License warnings.
		58m 23s

Subsystem	Report/Notes
Docker	ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6937/3/artifact/out/Dockerfile
GITHUB PR	#6937
Optional Tests	dupname asflicense codespell detsecrets shellcheck shelldocs jsonlint mvnsite unit
uname	Linux a650c4c4b202 5.15.0-106-generic #116-Ubuntu SMP Wed Apr 17 09:17:56 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / 749a358
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6937/3/testReport/
Max. process+thread count	550 (vs. ulimit of 5500)
modules	C: U:
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6937/3/console
versions	git=2.27.0 maven=3.6.3
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 19s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+0 🆗	jsonlint	0m 1s		jsonlint was not available.
+0 🆗	shelldocs	0m 1s		Shelldocs was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+0 🆗	mvndep	0m 22s		Maven dependency ordering for branch
+1 💚	mvninstall	17m 25s		trunk passed
+1 💚	mvnsite	0m 0s		trunk passed
+1 💚	shadedclient	19m 18s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 21s		Maven dependency ordering for patch
+1 💚	mvninstall	0m 0s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	0m 0s		the patch passed
+1 💚	shellcheck	0m 1s		No new issues.
+1 💚	shadedclient	19m 0s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	asflicense	0m 20s		The patch does not generate ASF License warnings.
		58m 17s

Subsystem	Report/Notes
Docker	ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6937/3/artifact/out/Dockerfile
GITHUB PR	#6937
Optional Tests	dupname asflicense codespell detsecrets jsonlint shellcheck shelldocs mvnsite unit
uname	Linux fef9781397fe 5.15.0-106-generic #116-Ubuntu SMP Wed Apr 17 09:17:56 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / 749a358
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6937/3/testReport/
Max. process+thread count	557 (vs. ulimit of 5500)
modules	C: U:
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6937/3/console
versions	git=2.25.1 maven=3.6.3 shellcheck=0.7.0
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

[pan3793]

I need to touch something to trigger "platform changes" to verify this PR.

[pan3793]

2. could there be a way to postpone the failure until later, while still failing the build?

@steveloughran I adopted this suggestion, how about now?

[pan3793]

also cc @adoroszlai @ayushtkn

[steveloughran]

was this failure the outcome desired? logs imply it, but we don't get the yetus report

[pan3793]

@steveloughran what do you mean "yetus report"? the GitHub comments are there as expected.