-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDFS-17575. SaslDataTransferClient should use SaslParticipant to create messages. #6933
Conversation
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @szetszwo for the patch, LGTM.
Thanks @sadanand48 and @arp7 for reviewing this. |
Hi @szetszwo / @arp7
Can try running Moreover, this part is also bit confusing:
Why are we checking |
@ayushtkn , thanks for pointing out the test failure. It somehow has not caught by hadoop-yetus. Just have reverted it. |
Description of PR
HDFS-17575
Currently, a SaslDataTransferClient may send a message without using its SaslParticipant as below.
Instead, it should use its SaslParticipant to create the response.
How was this patch tested?
By existing unit tests.
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?