HADOOP-19216. Upgrade Guice from 4.0 to 5.1.0 to support Java 17 (#6913). Contributed by Cheng Pan.

[pan3793]

Backport 25e28b4 (#6913) from trunk to branch-3.4

[steveloughran]

no need for me to review...it's already had the +1 vote

if yetus is happy, merge it yourself.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	12m 20s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ branch-3.4 Compile Tests _
+0 🆗	mvndep	14m 24s		Maven dependency ordering for branch
+1 💚	mvninstall	31m 25s		branch-3.4 passed
+1 💚	compile	16m 47s		branch-3.4 passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 💚	compile	15m 43s		branch-3.4 passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 💚	mvnsite	20m 55s		branch-3.4 passed
+1 💚	javadoc	8m 28s		branch-3.4 passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 💚	javadoc	7m 41s		branch-3.4 passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 💚	shadedclient	48m 16s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 35s		Maven dependency ordering for patch
-1 ❌	mvninstall	28m 26s	/patch-mvninstall-root.txt	root in the patch failed.
+1 💚	compile	16m 12s		the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 💚	javac	16m 12s		the patch passed
+1 💚	compile	15m 33s		the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 💚	javac	15m 33s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	14m 59s		the patch passed
+1 💚	shellcheck	0m 0s		No new issues.
+1 💚	javadoc	8m 17s		the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 💚	javadoc	7m 41s		the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 💚	shadedclient	49m 19s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	745m 5s	/patch-unit-root.txt	root in the patch passed.
+1 💚	asflicense	1m 36s		The patch does not generate ASF License warnings.
		1034m 56s

Reason	Tests
Failed junit tests	hadoop.hdfs.protocol.TestBlockListAsLongs
	hadoop.hdfs.server.datanode.TestLargeBlockReport

Subsystem	Report/Notes
Docker	ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6930/1/artifact/out/Dockerfile
GITHUB PR	#6930
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint shellcheck shelldocs
uname	Linux 8aefd7bc96f2 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	branch-3.4 / 2b62ad2
Default Java	Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6930/1/testReport/
Max. process+thread count	3797 (vs. ulimit of 5500)
modules	C: hadoop-project . U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6930/1/console
versions	git=2.25.1 maven=3.6.3 shellcheck=0.7.0
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

[ayushtkn]

compilation is failing:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6930/1/artifact/out/patch-mvninstall-root.txt

[pan3793]

YARN-11047 pinned Guice 4.0 for HBase 1, seems we can not upgrade Guice on branch-3.4 since HADOOP-19107 was not landed on branch-3.4

[steveloughran]

Does this mean we need to pull forward the dropping of hbase 1 to branch-3.4? I'm personally OK with that, though it should be discussed on yarn-dev