-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GUACAMOLE-377: Add client-side support for frame tracking and RemoteFX parameter. #681
GUACAMOLE-377: Add client-side support for frame tracking and RemoteFX parameter. #681
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of initial comments, and then I'll go back through, again, and make sure I didn't miss anything.
extensions/guacamole-display-statistics/src/main/resources/directives/guacClientStatistics.js
Outdated
Show resolved
Hide resolved
extensions/guacamole-display-statistics/src/main/resources/directives/guacClientStatistics.js
Outdated
Show resolved
Hide resolved
fecd14a
to
6dfb4f5
Compare
6dfb4f5
to
be90de9
Compare
What does the toolbar actually look like? Can you post a screenshot to this PR? |
Sure - I'll deploy a copy and grab a screenshot. |
The toolbar from the extension is added to the bottom of the client view and looks like this: It shows the rate that frames are being received from the remote desktop, the rate that the Guacamole server is processing received frames, the rate that the Guacamole client is rendering frames, and the rate that the Guacamole server is having to drop frames to compensate for processing delays on the client or server. |
Awesome! Looks great. |
Corresponding to apache/guacamole-server#363, this change adds support for enhanced frame tracking, an extension which implements that tracking and renders performance metrics in a toolbar, and the usual parameter definitions and translations.