[FLINK-27613] Add label for the session job to help list the session … #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…jobs in the same session cluster
gyfora
requested changes
Jun 13, 2022
|
|
||
| private static final ObjectMapper mapper = new ObjectMapper(); | ||
|
|
||
| public static <T> T convertToTargetType(HasMetadata resource, Class<T> targetType) |
There was a problem hiding this comment.
I think we don’t need this utility class, ObjectMapper already has a convertValue method that does exactly this.
| return resource; | ||
| } | ||
|
|
||
| private void patchInternalLabel(FlinkSessionJob flinkSessionJob) { |
There was a problem hiding this comment.
I think it would be clearer to call it simply setSessionTargetLabel
| @@ -109,4 +109,36 @@ webhooks: | |||
| operator: In | |||
| values: [{{- range .Values.watchNamespaces }}{{ . | quote }},{{- end}}] | |||
| {{- end }} | |||
| {{- end }} | |||
| --- | |||
There was a problem hiding this comment.
I think we should have a separate config flag to enable this. We should handle the validating and mutating webhooks independently of each other as some envs might want one but not the other.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…jobs in the same session cluster
This PR is based on #215 but use the mutator webhook to do the same thing