-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hessian bugfix, revert the override sequence of hessian, field of subclass should override that of parent class, not the other way around. #932
Hessian bugfix, revert the override sequence of hessian, field of subclass should override that of parent class, not the other way around. #932
Conversation
I have encountered this problem before, but I forgot to fix it. -_-|||. I would like to make a suggestion that you can move UT to this project @lovepoem . @chickenlj please review |
…de_filed_cannot_be_transmittedd_by_hession
The unit test is added . @qinliujie @chickenlj |
…de_filed_cannot_be_transmittedd_by_hession
…de_filed_cannot_be_transmittedd_by_hession
…' of https://github.com/lovepoem/dubbo into fixbug_overeide_filed_cannot_be_transmittedd_by_hession
…de_filed_cannot_be_transmittedd_by_hession
…de_filed_cannot_be_transmittedd_by_hession
Codecov Report
@@ Coverage Diff @@
## master #932 +/- ##
==========================================
+ Coverage 27.53% 27.89% +0.35%
==========================================
Files 789 789
Lines 41577 41578 +1
Branches 8476 8476
==========================================
+ Hits 11450 11597 +147
+ Misses 28078 27914 -164
- Partials 2049 2067 +18
Continue to review full report at Codecov.
|
Hessian bugfix, revert the override sequence of hessian, field of subclass should override that of parent class, not the other way around.
What is the purpose of the change
apache/dubbo-feature-test#1
Brief changelog
update JavaDeserializer.class , reverse the field list. Because the old type have a bug: the filed of parent class will cover the filed of sub class
because traversing fileds by while loop, the filed of sub-class is in the top of the List,when being transmitted to Map,it will be covered by the the filed of parent-class
Verifying this change
apache/dubbo-feature-test#2