Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hessian bugfix, revert the override sequence of hessian, field of subclass should override that of parent class, not the other way around. #932

Merged
merged 14 commits into from
Jan 18, 2018
Merged

Hessian bugfix, revert the override sequence of hessian, field of subclass should override that of parent class, not the other way around. #932

merged 14 commits into from
Jan 18, 2018

Conversation

lovepoem
Copy link
Member

@lovepoem lovepoem commented Nov 27, 2017

What is the purpose of the change

apache/dubbo-feature-test#1

Brief changelog

update JavaDeserializer.class , reverse the field list. Because the old type have a bug: the filed of parent class will cover the filed of sub class

because traversing fileds by while loop, the filed of sub-class is in the top of the List,when being transmitted to Map,it will be covered by the the filed of parent-class

Verifying this change

apache/dubbo-feature-test#2

@lovepoem lovepoem changed the title bugfix:修改hession序列化,子类方法/field重写父类方法/field数值为null 问题https://github.com/dubbo/dubbo-feature-test/issues/1 bugfix:修改hession序列化,子类方法/field重写父类方法/field数值为null 问题 Nov 28, 2017
@qinliujie
Copy link
Contributor

I have encountered this problem before, but I forgot to fix it. -_-|||. I would like to make a suggestion that you can move UT to this project @lovepoem . @chickenlj please review

@lovepoem
Copy link
Member Author

lovepoem commented Dec 1, 2017

The unit test is added . @qinliujie @chickenlj

@lovepoem lovepoem added this to the 2.5.9 milestone Dec 27, 2017
@lovepoem lovepoem added the type/bug Bugs to being fixed label Dec 27, 2017
@codecov-io
Copy link

Codecov Report

Merging #932 into master will increase coverage by 0.35%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #932      +/-   ##
==========================================
+ Coverage   27.53%   27.89%   +0.35%     
==========================================
  Files         789      789              
  Lines       41577    41578       +1     
  Branches     8476     8476              
==========================================
+ Hits        11450    11597     +147     
+ Misses      28078    27914     -164     
- Partials     2049     2067      +18
Impacted Files Coverage Δ
.../alibaba/com/caucho/hessian/io/JavaSerializer.java 57.59% <100%> (+4.43%) ⬆️
...libaba/com/caucho/hessian/util/IdentityIntMap.java 25% <0%> (-5.96%) ⬇️
...ba/dubbo/rpc/protocol/hessian/HessianProtocol.java 57.37% <0%> (-3.28%) ⬇️
...mon/serialize/support/dubbo/GenericDataOutput.java 63.85% <0%> (-2.11%) ⬇️
...mmon/serialize/support/dubbo/GenericDataInput.java 57.91% <0%> (-1.16%) ⬇️
...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java 83.33% <0%> (ø) ⬆️
...ibaba/com/caucho/hessian/io/BasicDeserializer.java 4.14% <0%> (+0.41%) ⬆️
...ibaba/com/caucho/hessian/io/SerializerFactory.java 56.84% <0%> (+0.68%) ⬆️
...a/dubbo/remoting/transport/netty/NettyChannel.java 61.25% <0%> (+1.25%) ⬆️
...baba/dubbo/remoting/transport/mina/MinaClient.java 59.42% <0%> (+1.44%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72cecba...205530b. Read the comment docs.

@chickenlj chickenlj changed the title bugfix:修改hession序列化,子类方法/field重写父类方法/field数值为null 问题 Hessian bugfix, revert the override sequence of hessian, field of subclass should override that of parent class, not the other way around. Jan 18, 2018
@chickenlj chickenlj changed the base branch from master to 2.5.x January 18, 2018 06:01
@chickenlj chickenlj merged commit 6f7a146 into apache:2.5.x Jan 18, 2018
@lovepoem lovepoem deleted the fixbug_overeide_filed_cannot_be_transmittedd_by_hession branch January 18, 2018 06:06
rolandhe pushed a commit to rolandhe/dubbo that referenced this pull request Sep 9, 2019
Hessian bugfix, revert the override sequence of hessian, field of subclass should override that of parent class, not the other way around.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Bugs to being fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants