Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the forced conversion in the ServiceInstanceMetadataCustomizer#customize method #7870

Merged
merged 1 commit into from
May 28, 2021

Conversation

BurningCN
Copy link
Member

What is the purpose of the change

Remove the forced conversion in the ServiceInstanceMetadataCustomizer#customize method

@codecov-commenter
Copy link

codecov-commenter commented May 26, 2021

Codecov Report

Merging #7870 (ad256fb) into master (e845e16) will increase coverage by 0.27%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7870      +/-   ##
============================================
+ Coverage     59.28%   59.55%   +0.27%     
- Complexity      529      557      +28     
============================================
  Files          1077     1088      +11     
  Lines         43565    43853     +288     
  Branches       6368     6400      +32     
============================================
+ Hits          25826    26116     +290     
+ Misses        14879    14839      -40     
- Partials       2860     2898      +38     
Impacted Files Coverage Δ
...nt/metadata/ServiceInstanceMetadataCustomizer.java 0.00% <0.00%> (ø)
.../dubbo/remoting/transport/MultiMessageHandler.java 80.00% <0.00%> (-20.00%) ⬇️
...bo/rpc/cluster/support/FailbackClusterInvoker.java 52.45% <0.00%> (-18.04%) ⬇️
...ting/exchange/support/header/HeartbeatHandler.java 83.72% <0.00%> (-9.31%) ⬇️
...va/org/apache/dubbo/rpc/support/ProtocolUtils.java 61.53% <0.00%> (-8.03%) ⬇️
...dubbo/remoting/exchange/support/DefaultFuture.java 80.34% <0.00%> (-6.84%) ⬇️
...o/remoting/transport/ChannelHandlerDispatcher.java 64.00% <0.00%> (-6.00%) ⬇️
...apache/dubbo/rpc/protocol/injvm/InjvmProtocol.java 72.22% <0.00%> (-5.56%) ⬇️
.../threadpool/manager/DefaultExecutorRepository.java 80.95% <0.00%> (-4.54%) ⬇️
.../rpc/protocol/dubbo/LazyConnectExchangeClient.java 49.45% <0.00%> (-4.40%) ⬇️
... and 98 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e845e16...ad256fb. Read the comment docs.

@AlbumenJ AlbumenJ merged commit 02cd7c3 into apache:master May 28, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants