Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dubbo-serialization-test add KryoSerialization2Test #7701

Merged
merged 1 commit into from
May 11, 2021

Conversation

xiaoheng1
Copy link
Contributor

What is the purpose of the change

dubbo-serialization-test add KryoSerialization2Test

see more detail from #7700

Brief changelog

Verifying this change

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented May 8, 2021

Codecov Report

Merging #7701 (73fb8f7) into master (f29663b) will increase coverage by 0.04%.
The diff coverage is 37.50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7701      +/-   ##
============================================
+ Coverage     59.18%   59.23%   +0.04%     
- Complexity      529      530       +1     
============================================
  Files          1076     1076              
  Lines         43540    43544       +4     
  Branches       6363     6363              
============================================
+ Hits          25771    25795      +24     
+ Misses        14903    14888      -15     
+ Partials       2866     2861       -5     
Impacted Files Coverage Δ Complexity Δ
...mon/serialize/kryo/optimized/KryoObjectInput2.java 14.00% <37.50%> (+14.00%) 0.00 <0.00> (ø)
...ng/transport/dispatcher/all/AllChannelHandler.java 82.75% <0.00%> (-6.90%) 0.00% <0.00%> (ø%)
...c/main/java/org/apache/dubbo/rpc/RpcException.java 80.00% <0.00%> (-3.34%) 0.00% <0.00%> (ø%)
...bo/rpc/cluster/support/FailbackClusterInvoker.java 67.21% <0.00%> (-3.28%) 0.00% <0.00%> (ø%)
.../dubbo/remoting/transport/netty4/NettyChannel.java 59.40% <0.00%> (-1.99%) 0.00% <0.00%> (ø%)
...e/dubbo/remoting/transport/netty4/NettyClient.java 69.56% <0.00%> (-1.45%) 0.00% <0.00%> (ø%)
...apache/dubbo/common/extension/ExtensionLoader.java 79.95% <0.00%> (+0.22%) 0.00% <0.00%> (ø%)
...n/java/org/apache/dubbo/common/utils/NetUtils.java 66.89% <0.00%> (+0.34%) 0.00% <0.00%> (ø%)
...pache/dubbo/registry/support/AbstractRegistry.java 79.62% <0.00%> (+1.48%) 0.00% <0.00%> (ø%)
...he/dubbo/remoting/transport/netty/NettyServer.java 73.68% <0.00%> (+3.50%) 9.00% <0.00%> (+1.00%)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f29663b...73fb8f7. Read the comment docs.

@AlbumenJ AlbumenJ merged commit 8592565 into apache:master May 11, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants