Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ZookeeperServiceDiscovery#getInstances not deal with healthyOnly #7692

Merged
merged 1 commit into from
May 11, 2021

Conversation

BurningCN
Copy link
Member

for issue #7691

@codecov-commenter
Copy link

codecov-commenter commented May 7, 2021

Codecov Report

Merging #7692 (83be59e) into master (f29663b) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7692   +/-   ##
=========================================
  Coverage     59.18%   59.19%           
  Complexity      529      529           
=========================================
  Files          1076     1076           
  Lines         43540    43547    +7     
  Branches       6363     6366    +3     
=========================================
+ Hits          25771    25778    +7     
- Misses        14903    14908    +5     
+ Partials       2866     2861    -5     
Impacted Files Coverage Δ Complexity Δ
.../registry/zookeeper/ZookeeperServiceDiscovery.java 30.95% <0.00%> (-2.82%) 0.00 <0.00> (ø)
.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java 62.06% <0.00%> (-10.35%) 0.00% <0.00%> (ø%)
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 86.66% <0.00%> (-1.91%) 16.00% <0.00%> (ø%)
...apache/dubbo/common/extension/ExtensionLoader.java 79.95% <0.00%> (+0.22%) 0.00% <0.00%> (ø%)
...pache/dubbo/registry/support/AbstractRegistry.java 78.51% <0.00%> (+0.37%) 0.00% <0.00%> (ø%)
...g/apache/dubbo/registry/consul/ConsulRegistry.java 60.58% <0.00%> (+0.58%) 31.00% <0.00%> (ø%)
.../dubbo/remoting/transport/netty4/NettyChannel.java 64.35% <0.00%> (+2.97%) 0.00% <0.00%> (ø%)
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 92.45% <0.00%> (+11.32%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f29663b...83be59e. Read the comment docs.

@AlbumenJ AlbumenJ merged commit a507445 into apache:master May 11, 2021
@BurningCN BurningCN deleted the feat_healthy_only branch May 14, 2021 04:10
AlbumenJ added a commit to AlbumenJ/dubbo that referenced this pull request May 28, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants