Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: The instance generated by DubboReference supports calling applyBeanPostProcessorsAfterInitialization #7644

Merged

Conversation

ph3636
Copy link

@ph3636 ph3636 commented Apr 27, 2021

What is the purpose of the change

There are some requirements to proxy DubboReference。

for example
#7615

Brief changelog

Verifying this change

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

ph3636 added 2 commits April 27, 2021 18:37
@24kpure
Copy link
Contributor

24kpure commented May 7, 2021

one feature with one commit maybe more cleaner

@ph3636
Copy link
Author

ph3636 commented May 8, 2021

one feature with one commit maybe more cleaner

Sorry, I don't understand what you mean. Is it because the direct use of applyBeanPostProcessorsAfterInitialization has a wide range of influence? How to design it reasonably, please guide me, because I think the normal initialization FactoryBean needs to go through applyBeanPostProcessorsAfterInitialization

@AlbumenJ
Copy link
Member

@ph3636 Thanks for your contribution.
I will merge it later.
Would you please add some unit test cases for this PR?

@ph3636
Copy link
Author

ph3636 commented May 18, 2021

@AlbumenJ OK, it's already here.#7790

vio-lin pushed a commit to vio-lin/incubator-dubbo that referenced this pull request Feb 22, 2023
* feature:  The instance generated by DubboReference supports calling applyBeanPostProcessorsAfterInitialization

* feature:  The instance generated by DubboReference supports calling applyBeanPostProcessorsAfterInitialization

Co-authored-by: ph3636 <tianxingguang@kanzhun.com>
(cherry picked from commit b5228af)
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants