Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore non-dubbo nacos services #7602

Merged
merged 3 commits into from
May 28, 2021

Conversation

CrazyHZM
Copy link
Member

What is the purpose of the change

fix Consumer aborted with ArrayIndexOutOfBoundsException when subscribing services from Nacos with '*' in group or version #6814

Brief changelog

Verifying this change

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2021

Codecov Report

Merging #7602 (68f3b38) into master (f8e25ec) will increase coverage by 0.14%.
The diff coverage is 7.14%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7602      +/-   ##
============================================
+ Coverage     59.11%   59.26%   +0.14%     
- Complexity      528      530       +2     
============================================
  Files          1076     1076              
  Lines         43443    43439       -4     
  Branches       6346     6346              
============================================
+ Hits          25681    25742      +61     
+ Misses        14917    14870      -47     
+ Partials       2845     2827      -18     
Impacted Files Coverage Δ Complexity Δ
...org/apache/dubbo/registry/nacos/NacosRegistry.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../apache/dubbo/registry/nacos/NacosServiceName.java 54.28% <33.33%> (-2.48%) 0.00 <0.00> (ø)
.../dubbo/registry/integration/RegistryDirectory.java 76.84% <0.00%> (+0.33%) 0.00% <0.00%> (ø%)
...org/apache/dubbo/registry/redis/RedisRegistry.java 49.01% <0.00%> (+0.39%) 27.00% <0.00%> (+1.00%)
...apache/dubbo/common/extension/ExtensionLoader.java 78.39% <0.00%> (+0.44%) 0.00% <0.00%> (ø%)
.../java/org/apache/dubbo/config/ReferenceConfig.java 65.87% <0.00%> (+0.47%) 0.00% <0.00%> (ø%)
...g/apache/dubbo/registry/consul/ConsulRegistry.java 60.58% <0.00%> (+0.58%) 31.00% <0.00%> (ø%)
...ubbo/registry/client/ServiceDiscoveryRegistry.java 42.85% <0.00%> (+0.59%) 0.00% <0.00%> (ø%)
...ache/dubbo/config/utils/ConfigValidationUtils.java 73.48% <0.00%> (+0.67%) 0.00% <0.00%> (ø%)
...rg/apache/dubbo/common/timer/HashedWheelTimer.java 80.06% <0.00%> (+0.68%) 0.00% <0.00%> (ø%)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8e25ec...68f3b38. Read the comment docs.

@AlbumenJ AlbumenJ merged commit 9915770 into apache:master May 28, 2021
@CrazyHZM CrazyHZM deleted the fix/Ignore_non-dubbo_nacos_services branch May 28, 2021 02:38
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants