Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify OptionUtil#prefixEndOf #5833

Merged
merged 2 commits into from
Apr 12, 2021
Merged

Conversation

GungnirLaevatain
Copy link
Contributor

What is the purpose of the change

endKey[i] < 0xff is always true, so could simplify this method

Brief changelog

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@AlbumenJ
Copy link
Member

@GungnirLaevatain Hi, thanks for your contribution.

Could you please provide more description about this pr?

Do all entries in endKey will always smaller than 0xff ?

@AlbumenJ AlbumenJ added the status/waiting-for-feedback Need reporters to triage label Apr 11, 2021
@GungnirLaevatain
Copy link
Contributor Author

GungnirLaevatain commented Apr 12, 2021

@GungnirLaevatain Hi, thanks for your contribution.

Could you please provide more description about this pr?

Do all entries in endKey will always smaller than 0xff ?

range of byte is -128~127, and 0xff is 255, so 'endKey[i] < 0xff' is always true . @AlbumenJ

@AlbumenJ AlbumenJ merged commit 8c291f8 into apache:master Apr 12, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/waiting-for-feedback Need reporters to triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants