Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dubbo_4344]fixspi配置多个tag解析错误问题(#4344) #4346

Merged
merged 3 commits into from
Jun 28, 2019

Conversation

zishinan
Copy link
Contributor

@zishinan zishinan commented Jun 19, 2019

What is the purpose of the change

#4344

Brief changelog

修改ExtensionLoader中的错误代码

Verifying this change

加入测试用例testMultiNames验证该bug

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

codecov-io commented Jun 19, 2019

Codecov Report

Merging #4346 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4346      +/-   ##
============================================
+ Coverage     62.85%   62.88%   +0.02%     
- Complexity      449      451       +2     
============================================
  Files           769      769              
  Lines         32995    32995              
  Branches       5215     5215              
============================================
+ Hits          20740    20749       +9     
+ Misses         9849     9846       -3     
+ Partials       2406     2400       -6
Impacted Files Coverage Δ Complexity Δ
...apache/dubbo/common/extension/ExtensionLoader.java 79.37% <100%> (+0.26%) 0 <0> (ø) ⬇️
...onfig/spring/extension/SpringExtensionFactory.java 78.04% <0%> (-7.32%) 0% <0%> (ø)
...pache/dubbo/registry/support/AbstractRegistry.java 78.54% <0%> (-1.54%) 0% <0%> (ø)
.../exchange/support/header/HeaderExchangeServer.java 66.98% <0%> (-0.95%) 0% <0%> (ø)
...g/apache/dubbo/registry/consul/ConsulRegistry.java 60.26% <0%> (+0.66%) 27% <0%> (ø) ⬇️
...ache/dubbo/registry/multiple/MultipleRegistry.java 63.38% <0%> (+0.7%) 21% <0%> (+1%) ⬆️
...bo/rpc/cluster/support/FailbackClusterInvoker.java 70.49% <0%> (+3.27%) 0% <0%> (ø) ⬇️
...c/main/java/org/apache/dubbo/rpc/RpcException.java 86.2% <0%> (+3.44%) 0% <0%> (ø) ⬇️
...e/dubbo/remoting/transport/netty/NettyChannel.java 62.35% <0%> (+4.7%) 21% <0%> (+1%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60c9d9d...75ce583. Read the comment docs.

Copy link
Contributor

@Leishunyu Leishunyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chickenlj chickenlj added this to the 2.7.3 milestone Jun 28, 2019
@cvictory cvictory modified the milestones: 2.7.3, 2.7.4 Jun 28, 2019
Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chickenlj chickenlj changed the base branch from master to 2.7.3-release June 28, 2019 08:44
@chickenlj chickenlj merged commit 9b7c697 into apache:2.7.3-release Jun 28, 2019
@zishinan zishinan deleted the fix4344 branch June 28, 2019 09:10
@cvictory cvictory modified the milestones: 2.7.4, 2.7.3 Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants