Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring Framework / Spring Boot Enhancements #1611

Merged
merged 12 commits into from
Apr 23, 2018
Merged

Conversation

mercyblitz
Copy link
Contributor

What is the purpose of the change

  • Bugfix : Legacy Spring annotation-driven issues on placeholder.
  • Refactor: The binder for Dubbo's config beans in order to adapter for Spring Framework and Spring Boot 1.x/2.0
  • Enhancement : Extraction of the Ops methods for Spring Boot Acutator

Brief changelog

Verifying this change

Run test-cases

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@lovepoem lovepoem mentioned this pull request Apr 21, 2018
@lovepoem
Copy link
Member

lovepoem commented Apr 21, 2018

1 个错误
61 个警告
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] dubbo-parent 2.6.1 ................................. SUCCESS [  1.940 s]
[INFO] Hessian Lite(Alibaba embed version) 3.2.2 .......... SUCCESS [  5.362 s]
[INFO] dubbo-common ....................................... SUCCESS [  6.706 s]
[INFO] dubbo-container .................................... SUCCESS [  0.095 s]
[INFO] dubbo-container-api ................................ SUCCESS [  1.103 s]
[INFO] dubbo-container-spring ............................. SUCCESS [  1.829 s]
[INFO] dubbo-container-log4j .............................. SUCCESS [  1.806 s]
[INFO] dubbo-container-logback ............................ SUCCESS [  2.008 s]
[INFO] dubbo-serialization ................................ SUCCESS [  0.074 s]
[INFO] dubbo-serialization-api ............................ SUCCESS [  1.035 s]
[INFO] dubbo-serialization-hessian2 ....................... SUCCESS [  2.728 s]
[INFO] dubbo-remoting ..................................... SUCCESS [  0.074 s]
[INFO] dubbo-remoting-api ................................. SUCCESS [  4.776 s]
[INFO] dubbo-remoting-netty ............................... SUCCESS [  2.831 s]
[INFO] dubbo-remoting-mina ................................ SUCCESS [  2.561 s]
[INFO] dubbo-remoting-grizzly ............................. SUCCESS [  1.460 s]
[INFO] dubbo-remoting-p2p ................................. SUCCESS [  2.747 s]
[INFO] dubbo-remoting-http ................................ SUCCESS [  2.600 s]
[INFO] dubbo-remoting-zookeeper ........................... SUCCESS [  2.637 s]
[INFO] dubbo-remoting-netty4 .............................. SUCCESS [  2.907 s]
[INFO] dubbo-rpc .......................................... SUCCESS [  0.068 s]
[INFO] dubbo-rpc-api ...................................... SUCCESS [  4.149 s]
[INFO] dubbo-rpc-dubbo .................................... SUCCESS [  4.214 s]
[INFO] dubbo-rpc-injvm .................................... SUCCESS [  2.614 s]
[INFO] dubbo-rpc-rmi ...................................... SUCCESS [  2.536 s]
[INFO] dubbo-rpc-hessian .................................. SUCCESS [  2.746 s]
[INFO] dubbo-rpc-http ..................................... SUCCESS [  1.474 s]
[INFO] dubbo-rpc-webservice ............................... SUCCESS [  1.565 s]
[INFO] dubbo-cluster ...................................... SUCCESS [  4.663 s]
[INFO] dubbo-registry ..................................... SUCCESS [  0.057 s]
[INFO] dubbo-registry-api ................................. SUCCESS [  3.869 s]
[INFO] dubbo-monitor ...................................... SUCCESS [  0.070 s]
[INFO] dubbo-monitor-api .................................. SUCCESS [  2.784 s]
[INFO] dubbo-filter ....................................... SUCCESS [  0.059 s]
[INFO] dubbo-filter-validation ............................ SUCCESS [  1.581 s]
[INFO] dubbo-filter-cache ................................. SUCCESS [  2.669 s]
[INFO] dubbo-registry-default ............................. SUCCESS [  3.476 s]
[INFO] dubbo-monitor-default .............................. SUCCESS [  2.845 s]
[INFO] dubbo-registry-multicast ........................... SUCCESS [  2.800 s]
[INFO] dubbo-serialization-jdk ............................ SUCCESS [  3.326 s]
[INFO] dubbo-config ....................................... SUCCESS [  0.058 s]
[INFO] dubbo-config-api ................................... SUCCESS [  4.618 s]
[INFO] dubbo-config-spring ................................ SUCCESS [  4.933 s]
[INFO] dubbo-rpc-thrift ................................... SUCCESS [  5.275 s]
[INFO] dubbo-rpc-memcached ................................ SUCCESS [  1.407 s]
[INFO] dubbo-rpc-redis .................................... SUCCESS [  1.479 s]
[INFO] dubbo-rpc-rest ..................................... SUCCESS [  2.248 s]
[INFO] dubbo-registry-zookeeper ........................... SUCCESS [  2.786 s]
[INFO] dubbo-registry-redis ............................... SUCCESS [  2.668 s]
[INFO] dubbo-demo ......................................... SUCCESS [  0.056 s]
[INFO] dubbo-demo-api ..................................... SUCCESS [  0.909 s]
[INFO] dubbo-demo-provider ................................ SUCCESS [  1.506 s]
[INFO] dubbo-demo-consumer ................................ SUCCESS [  1.295 s]
[INFO] dubbo-plugin ....................................... SUCCESS [  0.055 s]
[INFO] dubbo-qos .......................................... SUCCESS [  3.406 s]
[INFO] dubbo-serialization-fastjson ....................... SUCCESS [  3.301 s]
[INFO] dubbo-serialization-kryo ........................... SUCCESS [  3.848 s]
[INFO] dubbo-serialization-fst ............................ SUCCESS [  3.489 s]
[INFO] dubbo-dependencies-bom ............................. SUCCESS [  0.009 s]
[INFO] dubbo-bom .......................................... SUCCESS [  0.007 s]
[INFO] dubbo-all .......................................... FAILURE [05:43 min]
[INFO] dubbo-test ......................................... SKIPPED
[INFO] dubbo-test-benchmark ............................... SKIPPED
[INFO] dubbo-test-compatibility ........................... SKIPPED
[INFO] dubbo-test-spring3 ................................. SKIPPED
[INFO] dubbo-test-integration ............................. SKIPPED
[INFO] dubbo-test-examples 2.6.1 .......................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 08:02 min
[INFO] Finished at: 2018-04-22T00:03:15+08:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:3.0.0:jar (attach-javadoc) on project dubbo: MavenReportException: Error while generating Javadoc: 
[ERROR] Exit code: 1 - /Users/wx/projects/mercy-dubbo/hessian-lite/src/main/java/com/alibaba/com/caucho/hessian/io/AbstractHessianOutput.java:125: 警告 - @param argument "method" 不是参数名称。
[ERROR] /Users/wx/projects/mercy-dubbo/hessian-lite/src/main/java/com/alibaba/com/caucho/hessian/io/AbstractHessianOutput.java:246: 警告 - @param argument "value" 不是参数名称。
[ERROR] /Users/wx/projects/mercy-dubbo/hessian-lite/src/main/java/com/alibaba/com/caucho/hessian/io/AbstractHessianOutput.java:284: 警告 - @param argument "value" 不是参数名称。
[ERROR] /Users/wx/projects/mercy-dubbo/hessian-lite/src/main/java/com/alibaba/com/caucho/hessian/io/AbstractHessianOutput.java:303: 警告 - @param argument "value" 不是参数名称。
[ERROR] /Users/wx/projects/mercy-dubbo/hessian-lite/src/main/java/com/alibaba/com/caucho/hessian/io/AbstractHessianOutput.java:322: 警告 - @param argument "value" 不是参数名称。
[ERROR] /Users/wx/projects/mercy-dubbo/hessian-lite/src/main/java/com/alibaba/com/caucho/hessian/io/AbstractHessianOutput.java:340: 警告 - @param argument "value" 不是参数名称。
[ERROR] /Users/wx/projects/mercy-dubbo/hessian-lite/src/main/java/com/alibaba/com/caucho/hessian/io/AbstractHessianOutput.java:354: 警告 - @param argument "value" 不是参数名称。
[ERROR] /Users/wx/projects/mercy-dubbo/hessian-lite/src/main/java/com/alibaba/com/caucho/hessian/io/AbstractHessianOutput.java:424: 警告 - 标记 > 的用法无效
[ERROR] /Users/wx/projects/mercy-dubbo/hessian-lite/src/main/java/com/alibaba/com/caucho/hessian/io/Hessian2Output.java:166: 警告 - @param argument "method" 不是参数名称。
[ERROR] /Users/wx/projects/mercy-dubbo/hessian-lite/src/main/java/com/alibaba/com/caucho/hessian/io/Hessian2Output.java:481: 警告 - 标记 > 的用法无效
[ERROR] /Users/wx/projects/mercy-dubbo/hessian-lite/src/main/java/com/alibaba/com/caucho/hessian/io/Hessian2Output.java:481: 警告 - 标记 > 的用法无效
[ERROR] /Users/wx/projects/mercy-dubbo/hessian-lite/src/main/java/com/alibaba/com/caucho/hessian/io/Hessian2Output.java:481: 警告 - 标记 > 的用法无效
[ERROR] /Users/wx/projects/mercy-dubbo/hessian-lite/src/main/java/com/alibaba/com/caucho/hessian/io/Hessian2Output.java:821: 警告 - @param argument "value" 不是参数名称。
[ERROR] /Users/wx/projects/mercy-dubbo/hessian-lite/src/main/java/com/alibaba/com/caucho/hessian/io/Hessian2Output.java:938: 警告 - @param argument "value" 不是参数名称。
[ERROR] /Users/wx/projects/mercy-dubbo/hessian-lite/src/main/java/com/alibaba/com/caucho/hessian/io/Hessian2Output.java:1002: 警告 - @param argument "value" 不是参数名称。
[ERROR] /Users/wx/projects/mercy-dubbo/hessian-lite/src/main/java/com/alibaba/com/caucho/hessian/io/Hessian2Output.java:1029: 警告 - @param argument "value" 不是参数名称。
[ERROR] /Users/wx/projects/mercy-dubbo/hessian-lite/src/main/java/com/alibaba/com/caucho/hessian/io/HessianOutput.java:165: 警告 - @param argument "method" 不是参数名称。
[ERROR] /Users/wx/projects/mercy-dubbo/hessian-lite/src/main/java/com/alibaba/com/caucho/hessian/io/HessianOutput.java:258: 警告 - 标记 > 的用法无效
[ERROR] /Users/wx/projects/mercy-dubbo/hessian-lite/src/main/java/com/alibaba/com/caucho/hessian/io/HessianOutput.java:259: 警告 - 标记 > 的用法无效
[ERROR] /Users/wx/projects/mercy-dubbo/hessian-lite/src/main/java/com/alibaba/com/caucho/hessian/io/HessianOutput.java:261: 警告 - 标记 > 的用法无效
[ERROR] /Users/wx/projects/mercy-dubbo/hessian-lite/src/main/java/com/alibaba/com/caucho/hessian/io/HessianOutput.java:262: 警告 - 标记 > 的用法无效
[ERROR] /Users/wx/projects/mercy-dubbo/hessian-lite/src/main/java/com/alibaba/com/caucho/hessian/io/HessianOutput.java:264: 警告 - 标记 > 的用法无效
[ERROR] /Users/wx/projects/mercy-dubbo/hessian-lite/src/main/java/com/alibaba/com/caucho/hessian/io/HessianOutput.java:502: 警告 - @param argument "value" 不是参数名称。
[ERROR] /Users/wx/projects/mercy-dubbo/hessian-lite/src/main/java/com/alibaba/com/caucho/hessian/io/HessianOutput.java:574: 警告 - @param argument "value" 不是参数名称。
[ERROR] /Users/wx/projects/mercy-dubbo/hessian-lite/src/main/java/com/alibaba/com/caucho/hessian/io/HessianOutput.java:622: 警告 - @param argument "value" 不是参数名称。
[ERROR] /Users/wx/projects/mercy-dubbo/hessian-lite/src/main/java/com/alibaba/com/caucho/hessian/io/HessianOutput.java:646: 警告 - @param argument "value" 不是参数名称。
[ERROR] /Users/wx/projects/mercy-dubbo/hessian-lite/src/main/java/com/alibaba/com/caucho/hessian/io/HessianSerializerOutput.java:105: 警告 - @param argument "object" 不是参数名称。
[ERROR] /Users/wx/projects/mercy-dubbo/hessian-lite/src/main/java/com/alibaba/com/caucho/hessian/io/MapDeserializer.java:101: 警告 - 标记 < 的用法无效
[ERROR] /Users/wx/projects/mercy-dubbo/hessian-lite/src/main/java/com/alibaba/com/caucho/hessian/io/MapDeserializer.java:101: 警告 - 标记 > 的用法无效
[ERROR] /Users/wx/projects/mercy-dubbo/hessian-lite/src/main/java/com/alibaba/com/caucho/hessian/io/MapDeserializer.java:101: 警告 - 标记 & 的用法无效
[ERROR] /Users/wx/projects/mercy-dubbo/dubbo-common/src/main/java/com/alibaba/dubbo/common/concurrent/ExecutionList.java:38: 警告 - 标记@linkplain: 找不到引用: MoreExecutors#sameThreadExecutorinline execution
[ERROR] /Users/wx/projects/mercy-dubbo/dubbo-common/src/main/java/com/alibaba/dubbo/common/concurrent/ExecutionList.java:68: 警告 - 标记@link: 找不到引用: MoreExecutors#sameThreadExecutor
[ERROR] /Users/wx/projects/mercy-dubbo/dubbo-common/src/main/java/com/alibaba/dubbo/common/concurrent/ListenableFuture.java:39: 警告 - 标记@link: 找不到引用: Futures#allAsList(Iterable)Futures.allAsList
[ERROR] /Users/wx/projects/mercy-dubbo/dubbo-common/src/main/java/com/alibaba/dubbo/common/concurrent/ListenableFuture.java:46: 警告 - 标记@link: 找不到引用: Futures#addCallbackFutures.addCallback
[ERROR] /Users/wx/projects/mercy-dubbo/dubbo-common/src/main/java/com/alibaba/dubbo/common/concurrent/ListenableFuture.java:68: 警告 - 标记@link: 找不到引用: ListeningExecutorService
[ERROR] /Users/wx/projects/mercy-dubbo/dubbo-common/src/main/java/com/alibaba/dubbo/common/concurrent/ListenableFuture.java:68: 警告 - 标记@link: 找不到引用: MoreExecutors#listeningDecorator(ExecutorService)MoreExecutors.listeningDecorator
[ERROR] /Users/wx/projects/mercy-dubbo/dubbo-common/src/main/java/com/alibaba/dubbo/common/concurrent/ListenableFuture.java:73: 警告 - 标记@link: 找不到引用: SettableFuture
[ERROR] /Users/wx/projects/mercy-dubbo/dubbo-common/src/main/java/com/alibaba/dubbo/common/concurrent/ListenableFuture.java:74: 警告 - 标记@link: 找不到引用: AbstractFuture
[ERROR] /Users/wx/projects/mercy-dubbo/dubbo-common/src/main/java/com/alibaba/dubbo/common/concurrent/ListenableFuture.java:95: 警告 - 标记@linkplain: 找不到引用: MoreExecutors#sameThreadExecutorinline execution
[ERROR] /Users/wx/projects/mercy-dubbo/dubbo-common/src/main/java/com/alibaba/dubbo/common/concurrent/ListenableFuture.java:100: 警告 - 标记@link: 找不到引用: MoreExecutors#sameThreadExecutor
[ERROR] /Users/wx/projects/mercy-dubbo/dubbo-common/src/main/java/com/alibaba/dubbo/common/concurrent/ListenableFuture.java:95: 警告 - 标记@linkplain: 找不到引用: MoreExecutors#sameThreadExecutorinline execution
[ERROR] /Users/wx/projects/mercy-dubbo/dubbo-common/src/main/java/com/alibaba/dubbo/common/concurrent/ListenableFuture.java:100: 警告 - 标记@link: 找不到引用: MoreExecutors#sameThreadExecutor
[ERROR] /Users/wx/projects/mercy-dubbo/dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/CompatibleTypeUtils.java:44: 警告 - 标记 > 的用法无效
[ERROR] /Users/wx/projects/mercy-dubbo/dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/CompatibleTypeUtils.java:45: 警告 - 标记 > 的用法无效
[ERROR] /Users/wx/projects/mercy-dubbo/dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/CompatibleTypeUtils.java:46: 警告 - 标记 > 的用法无效
[ERROR] /Users/wx/projects/mercy-dubbo/dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/ConfigUtils.java:187: 警告 - 标记 > 的用法无效
[ERROR] /Users/wx/projects/mercy-dubbo/dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/ConfigUtils.java:187: 警告 - 标记 > 的用法无效
[ERROR] /Users/wx/projects/mercy-dubbo/dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/ReflectUtils.java:228: 警告 - 标记 > 的用法无效
[ERROR] /Users/wx/projects/mercy-dubbo/dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/ReflectUtils.java:331: 警告 - 标记 > 的用法无效
[ERROR] /Users/wx/projects/mercy-dubbo/dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/ReflectUtils.java:332: 警告 - 标记 > 的用法无效
[ERROR] /Users/wx/projects/mercy-dubbo/dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/ReflectUtils.java:367: 警告 - 标记 > 的用法无效
[ERROR] /Users/wx/projects/mercy-dubbo/dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/ReflectUtils.java:385: 警告 - 标记 > 的用法无效
[ERROR] /Users/wx/projects/mercy-dubbo/dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/ReflectUtils.java:386: 警告 - 标记 > 的用法无效
[ERROR] /Users/wx/projects/mercy-dubbo/dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/ReflectUtils.java:435: 警告 - 标记 > 的用法无效
[ERROR] /Users/wx/projects/mercy-dubbo/dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/ReflectUtils.java:436: 警告 - 标记 > 的用法无效
[ERROR] /Users/wx/projects/mercy-dubbo/dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/ReflectUtils.java:517: 警告 - 标记 > 的用法无效
[ERROR] /Users/wx/projects/mercy-dubbo/dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/ReflectUtils.java:545: 警告 - 标记 > 的用法无效
[ERROR] /Users/wx/projects/mercy-dubbo/dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/ReflectUtils.java:611: 警告 - 标记 > 的用法无效
[ERROR] /Users/wx/projects/mercy-dubbo/dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/ReflectUtils.java:612: 警告 - 标记 > 的用法无效
[ERROR] /Users/wx/projects/mercy-dubbo/dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/ReflectUtils.java:676: 警告 - 标记 > 的用法无效
[ERROR] /Users/wx/projects/mercy-dubbo/dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/ReflectUtils.java:677: 警告 - 标记 > 的用法无效
[ERROR] javadoc: 错误 - 构建组件时出现异常错误: MethodsSummary
[ERROR] 	(java.lang.NullPointerException)
[ERROR] 如果在 Bug Database (http://bugs.java.com) 中没有找到重复项, 
[ERROR] 请通过 Java Bug 报告页 (http://bugreport.java.com) 针对该 
[ERROR] javadoc 工具建立 Bug。请在报告中附上错误消息和以下诊断信息。谢谢。
[ERROR] java.lang.NullPointerException
[ERROR] 	at jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.util.Utils.getEnclosingTypeElement(Utils.java:2574)
[ERROR] 	at jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.util.CommentHelper.getReferencedClass(CommentHelper.java:371)
[ERROR] 	at jdk.javadoc/jdk.javadoc.internal.doclets.formats.html.HtmlDocletWriter.seeTagToContent(HtmlDocletWriter.java:1510)
[ERROR] 	at jdk.javadoc/jdk.javadoc.internal.doclets.formats.html.HtmlDocletWriter$2.visitLink(HtmlDocletWriter.java:1949)
[ERROR] 	at jdk.javadoc/jdk.javadoc.internal.doclets.formats.html.HtmlDocletWriter$2.visitLink(HtmlDocletWriter.java:1797)
[ERROR] 	at jdk.compiler/com.sun.tools.javac.tree.DCTree$DCLink.accept(DCTree.java:500)
[ERROR] 	at jdk.compiler/com.sun.source.util.SimpleDocTreeVisitor.visit(SimpleDocTreeVisitor.java:79)
[ERROR] 	at jdk.javadoc/jdk.javadoc.internal.doclets.formats.html.HtmlDocletWriter.commentTagsToContent(HtmlDocletWriter.java:2017)
[ERROR] 	at jdk.javadoc/jdk.javadoc.internal.doclets.formats.html.HtmlDocletWriter.addCommentTags(HtmlDocletWriter.java:1719)
[ERROR] 	at jdk.javadoc/jdk.javadoc.internal.doclets.formats.html.HtmlDocletWriter.addCommentTags(HtmlDocletWriter.java:1700)
[ERROR] 	at jdk.javadoc/jdk.javadoc.internal.doclets.formats.html.HtmlDocletWriter.addSummaryComment(HtmlDocletWriter.java:1670)
[ERROR] 	at jdk.javadoc/jdk.javadoc.internal.doclets.formats.html.SubWriterHolderWriter.addIndexComment(SubWriterHolderWriter.java:207)
[ERROR] 	at jdk.javadoc/jdk.javadoc.internal.doclets.formats.html.SubWriterHolderWriter.addSummaryLinkComment(SubWriterHolderWriter.java:243)
[ERROR] 	at jdk.javadoc/jdk.javadoc.internal.doclets.formats.html.AbstractMemberWriter.addMemberSummary(AbstractMemberWriter.java:533)
[ERROR] 	at jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.builders.MemberSummaryBuilder.buildSummary(MemberSummaryBuilder.java:359)
[ERROR] 	at jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.builders.MemberSummaryBuilder.addSummary(MemberSummaryBuilder.java:515)
[ERROR] 	at jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.builders.MemberSummaryBuilder.buildMethodsSummary(MemberSummaryBuilder.java:309)
[ERROR] 	at jdk.internal.reflect.GeneratedMethodAccessor34.invoke(Unknown Source)
[ERROR] 	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[ERROR] 	at java.base/java.lang.reflect.Method.invoke(Method.java:564)
[ERROR] 	at jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.builders.AbstractBuilder.build(AbstractBuilder.java:157)
[ERROR] 	at jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.builders.AbstractMemberBuilder.build(AbstractMemberBuilder.java:87)
[ERROR] 	at jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.builders.AbstractBuilder.buildChildren(AbstractBuilder.java:200)
[ERROR] 	at jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.builders.ClassBuilder.buildMemberSummary(ClassBuilder.java:333)
[ERROR] 	at jdk.internal.reflect.GeneratedMethodAccessor28.invoke(Unknown Source)
[ERROR] 	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[ERROR] 	at java.base/java.lang.reflect.Method.invoke(Method.java:564)
[ERROR] 	at jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.builders.AbstractBuilder.build(AbstractBuilder.java:157)
[ERROR] 	at jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.builders.AbstractBuilder.buildChildren(AbstractBuilder.java:200)
[ERROR] 	at jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.builders.ClassBuilder.buildClassDoc(ClassBuilder.java:155)
[ERROR] 	at jdk.internal.reflect.GeneratedMethodAccessor13.invoke(Unknown Source)
[ERROR] 	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[ERROR] 	at java.base/java.lang.reflect.Method.invoke(Method.java:564)
[ERROR] 	at jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.builders.AbstractBuilder.build(AbstractBuilder.java:157)
[ERROR] 	at jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.builders.ClassBuilder.build(ClassBuilder.java:125)
[ERROR] 	at jdk.javadoc/jdk.javadoc.internal.doclets.formats.html.HtmlDoclet.generateClassFiles(HtmlDoclet.java:263)
[ERROR] 	at jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.AbstractDoclet.generateClassFiles(AbstractDoclet.java:273)
[ERROR] 	at jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.AbstractDoclet.startGeneration(AbstractDoclet.java:207)
[ERROR] 	at jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.AbstractDoclet.run(AbstractDoclet.java:117)
[ERROR] 	at jdk.javadoc/jdk.javadoc.doclet.StandardDoclet.run(StandardDoclet.java:72)
[ERROR] 	at jdk.javadoc/jdk.javadoc.internal.tool.Start.parseAndExecute(Start.java:574)
[ERROR] 	at jdk.javadoc/jdk.javadoc.internal.tool.Start.begin(Start.java:423)
[ERROR] 	at jdk.javadoc/jdk.javadoc.internal.tool.Start.begin(Start.java:340)
[ERROR] 	at jdk.javadoc/jdk.javadoc.internal.tool.Main.execute(Main.java:63)
[ERROR] 	at jdk.javadoc/jdk.javadoc.internal.tool.Main.main(Main.java:52)
[ERROR] 
[ERROR] Command line was: /Library/Java/JavaVirtualMachines/jdk-9.0.4.jdk/Contents/Home/bin/javadoc @options @packages
[ERROR] 
[ERROR] Refer to the generated Javadoc files in '/Users/wx/projects/mercy-dubbo/all/target/apidocs' dir.
[ERROR] 
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <goals> -rf :dubbo

Java9's failure seems caused by javadoc

@htynkn
Copy link
Member

htynkn commented Apr 22, 2018

@lovepoem I can reproduce same issue now.
Master branch build is pass. this issue is only for this pr branch.

The error happens after dubbo-common module. So some change in this pr cause java doc fail.

void setIgnoreInvalidFields(boolean ignoreInvalidFields);

/**
* Bind the properties to {@link C Dubbo Config} Object under specified prefix.
Copy link
Member

@htynkn htynkn Apr 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mercyblitz could you remove this link from javadoc? this is the root cause for java9 CI build fail.
I clone your repo and did a test. Please refer to my change (htynkn@8d6ec74) and travis CI status:
https://travis-ci.org/htynkn/dubbo/builds/369700581

After remove this link, the CI will pass

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool. I see CI pass now

Remove invalid JavaDoc
@codecov-io
Copy link

codecov-io commented Apr 23, 2018

Codecov Report

Merging #1611 into master will increase coverage by 0.85%.
The diff coverage is 83.53%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #1611      +/-   ##
===========================================
+ Coverage     34.54%   35.4%   +0.85%     
- Complexity     3686    3777      +91     
===========================================
  Files           621     628       +7     
  Lines         30875   30994     +119     
  Branches       5448    5456       +8     
===========================================
+ Hits          10667   10972     +305     
+ Misses        18372   18129     -243     
- Partials       1836    1893      +57
Impacted Files Coverage Δ Complexity Δ
...com/alibaba/dubbo/config/spring/ReferenceBean.java 25.92% <ø> (ø) 9 <0> (ø) ⬇️
...a/com/alibaba/dubbo/config/spring/ServiceBean.java 28.67% <ø> (ø) 15 <0> (ø) ⬇️
...onvert/converter/StringArrayToStringConverter.java 100% <100%> (ø) 3 <3> (?)
...beans/factory/annotation/ReferenceBeanBuilder.java 87.17% <100%> (+3.3%) 12 <2> (+1) ⬆️
...dubbo/config/spring/util/PropertySourcesUtils.java 84.61% <100%> (+1.28%) 6 <2> (+1) ⬆️
...g/convert/converter/StringArrayToMapConverter.java 100% <100%> (ø) 3 <3> (?)
...annotation/ServiceAnnotationBeanPostProcessor.java 85.18% <100%> (+0.33%) 33 <4> (ø) ⬇️
...ontext/annotation/DubboConfigBindingRegistrar.java 92.72% <100%> (-0.03%) 15 <4> (-2)
...g/context/properties/DefaultDubboConfigBinder.java 100% <100%> (ø) 2 <2> (?)
.../alibaba/dubbo/config/spring/util/ObjectUtils.java 50% <50%> (ø) 1 <1> (?)
... and 417 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a65c9e2...5d72ddf. Read the comment docs.

@mercyblitz mercyblitz merged commit a2a7706 into apache:master Apr 23, 2018

String interfaceName = resolveInterfaceName(reference, beanClass);

String key = reference.group() + "/" + interfaceName + ":" + reference.version();
String key = reference.url() + "/" + interfaceName +
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using StringBuilder maybe more nice .

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the same in JVM, switch to StringBuilder is welcome

private ConversionService getConversionService() {
DefaultConversionService conversionService = new DefaultConversionService();
conversionService.addConverter(new StringArrayToStringConverter());
conversionService.addConverter(new StringArrayToMapConverter());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to convert other scenes ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's used to convert value of attributes of @Service and @Reference to required type.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For example , @Service#parameters() will be converted to Map

@chickenlj chickenlj added this to the 2.6.2 milestone Apr 23, 2018
rolandhe pushed a commit to rolandhe/dubbo that referenced this pull request Sep 9, 2019
* Manually merge pull request apache#1486, to make travis ci and codecov work after apache incubator transition.

* Polish apache#1306

* Optimize imports

* Optimize imports

* Update DubboConfigBinder.java

Remove invalid JavaDoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants