Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leak in HttpPostRequestDecoder #14741

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Fix memory leak in HttpPostRequestDecoder #14741

merged 1 commit into from
Oct 2, 2024

Conversation

oxsean
Copy link
Collaborator

@oxsean oxsean commented Sep 30, 2024

What is the purpose of the change?

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

oxsean
oxsean commented Sep 30, 2024
View reviewed changes
...ple/src/main/java/org/apache/dubbo/rpc/protocol/tri/h12/AbstractServerTransportListener.java
// customizer RpcInvocation
headerFilters.forEach(f -> f.invoke(invoker, inv));
HeaderFilter[] headerFilters =
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lost when merging code.

oxsean
oxsean commented Sep 30, 2024
View reviewed changes
...remoting/dubbo-remoting-http12/src/main/java/org/apache/dubbo/remoting/http12/HttpUtils.java
@@ -51,6 +54,7 @@

public final class HttpUtils {

public static final ByteBufAllocator HEAP_ALLOC = new UnpooledByteBufAllocator(false, false);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using heap instend of dicrect

@AlbumenJ AlbumenJ merged commit b9a2f19 into apache:3.3 Oct 2, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlbumenJ AlbumenJ AlbumenJ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oxsean @AlbumenJ