Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Improve Numeric Validation Logic #14532

Conversation

jieyangxchen
Copy link

What is the purpose of the change

The purpose of this change is to improve the numeric validation logic in the timeout configuration code. This is achieved by replacing the previous isNotEmpty check with isNumeric and trim, ensuring that only valid numeric values are parsed, which enhances the robustness and readability of the code while reducing the risk of NumberFormatException.

Brief changelog

  • Replaced isNotEmpty check with isNumeric and trim to validate numeric input more accurately.
  • Optimized the try-catch logic to improve code readability and error handling efficiency.
  • Enhanced input validation for timeout configuration to ensure only valid numeric values are parsed.

Verifying this change

This change can be verified by running the existing unit tests that cover timeout configuration scenarios.

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

- Replaced the isNotEmpty check with isNumeric and trim to ensure that only valid numeric values are parsed.
- This change reduces the risk of NumberFormatException by validating the string before attempting to parse it as an integer.
- Optimized the try-catch logic, enhancing the readability of the code.
Improves input validation for timeout configuration.
@jieyangxchen jieyangxchen force-pushed the refactor/validate-numeric-timeout branch from 7745b14 to e721025 Compare August 13, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant