-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix triple-servlet-dependencies #14452
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's necessary to make these changes because the files are already shaded to the dubbo.jar, please check whether dubbo.jar is correctly packaged, adding it is acceptable to avoid idea compilation problems, but it needs to set
<optional>true</optional>
<groupId>org.apache.dubbo</groupId> | ||
<artifactId>dubbo-triple-servlet</artifactId> | ||
<version>${project.version}</version> | ||
</dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<optional>true</optional>
<groupId>org.apache.dubbo</groupId> | ||
<artifactId>dubbo-triple-servlet</artifactId> | ||
<version>${project.version}</version> | ||
</dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<optional>true</optional>
<groupId>org.apache.dubbo</groupId> | ||
<artifactId>dubbo-rpc-triple</artifactId> | ||
<version>${project.version}</version> | ||
</dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<optional>true</optional>
|
What is the purpose of the change
fix triple-servlet-dependencies.
![图片](https://private-user-images.githubusercontent.com/147408835/350659717-a87ca2b6-5b60-4483-8687-38f1c4e9b4da.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYxMDQzMDYsIm5iZiI6MTcyNjEwNDAwNiwicGF0aCI6Ii8xNDc0MDg4MzUvMzUwNjU5NzE3LWE4N2NhMmI2LTViNjAtNDQ4My04Njg3LTM4ZjFjNGU5YjRkYS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwOTEyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDkxMlQwMTIwMDZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1kMGZkN2M1ZmM3YjIwNWJlNTA5YjIyMTI3ZGUxOTM1ZDg2YTI4NWQ4NzI0OGJkZTk0M2NkNmZhNjE2MTY5YmYwJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.OulJVvieXx9I1KZrILqvOIAjTJkwOUxiwlFTOlPsF5s)
![图片](https://private-user-images.githubusercontent.com/147408835/350659742-5e6ecc40-2c2b-4ced-80c4-64b0dc095fb2.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYxMDQzMDYsIm5iZiI6MTcyNjEwNDAwNiwicGF0aCI6Ii8xNDc0MDg4MzUvMzUwNjU5NzQyLTVlNmVjYzQwLTJjMmItNGNlZC04MGM0LTY0YjBkYzA5NWZiMi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwOTEyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDkxMlQwMTIwMDZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT01N2YxMTQ2Y2U4NGI0ZGVjOGYxNGJhZWZjMjc5ZjNkMmRkOWFkYjNkZWY1ZDZhOWUyYjIzZjJlZGY1MGRkNThkJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.3iMSEtod4c5K0MTEVNV3oVjIOZhCSErkhYXfFvgY7iM)
Brief changelog
add related dependencies in pom.xml
Verifying this change
No
Checklist