Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Resolved issue where ServiceInfo with null protocol was blocking… #14421

Merged

Conversation

QingJuBaiTang
Copy link
Contributor

@QingJuBaiTang QingJuBaiTang commented Jul 11, 2024

… the refresh of invokers

What is the purpose of the change

If a spring cloud service's mapping is uploaded to the metadata center, the protocol field of ServiceInfo obtained through getMatchedServiceInfos is null, which eventually causes the invoker update to fail.

lQLPJwt0DxKVgUvNA1TNCeSwWN68PTPd3i0GeOGKdzg7AA_2532_852

Brief changelog

Verifying this change

Checklist

  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@wcy666103
Copy link
Contributor

please re-submit in english only.

@wcy666103
Copy link
Contributor

use mvn spotless:apply to format code

@QingJuBaiTang QingJuBaiTang force-pushed the bugfix/null-protocol-refresh-invoker-fail branch from 50a4a70 to b5bd438 Compare July 11, 2024 10:31
Copy link

sonarcloud bot commented Jul 11, 2024

@AlbumenJ
Copy link
Member

We should remove SpringCloudServiceInstanceNotificationCustomizer in the future

@QingJuBaiTang
Copy link
Contributor Author

Because we are currently using this code and have encountered this bug. Could you please review my fix to see if it actually resolves the issue and does not introduce any other potential problems? @AlbumenJ

@AlbumenJ AlbumenJ merged commit 342121c into apache:3.2 Jul 16, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants