Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix DubboRelaxedBinding2AutoConfiguration and DubboAutoConfiguration created to early #14255

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

xixingya
Copy link
Contributor

What is the purpose of the change

fix DubboRelaxedBinding2AutoConfiguration and DubboAutoConfiguration created to early

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

see #14253 and dubbo 3.3 pr see #13461

Copy link

sonarcloud bot commented May 29, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@AlbumenJ
Copy link
Member

@CrazyHZM PTAL

@CrazyHZM
Copy link
Member

CrazyHZM commented Jun 4, 2024

@xixingya Please describe the scene.

@xixingya
Copy link
Contributor Author

xixingya commented Jun 5, 2024

@xixingya Please describe the scene.

@CrazyHZM #14253 this issue, dubbo 3.2 will have warn log

@FoghostCn
Copy link
Contributor

ref #13461

@CrazyHZM CrazyHZM merged commit d3eef04 into apache:3.2 Jun 6, 2024
19 checks passed
@CrazyHZM CrazyHZM added this to the 3.2.14 milestone Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants