Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New metadata service #14210

Merged
merged 30 commits into from
Jun 25, 2024

Conversation

namelessssssssssss
Copy link
Contributor

@namelessssssssssss namelessssssssssss commented May 20, 2024

Purpose of the Change

This PR introduces a new version of MetadataService (V2) based on Protobuf, which provides better compatibility with dubbo-go.

See #13584

Brief Changelog

To use MetadataServiceV2, the application must meet the following requirements:

  • The application has imported Protobuf dependencies.
  • metadataServiceProtocol is configured as 'tri', or at least one service is using the triple protocol.

Currently, MetadataServiceV2 will automatically export along with MetadataService (V1, on the same port) if the above requirements are satisfied. If onlyUseMetadataV2 is set to true, only MetadataServiceV2 will be exported. If the above requirements are not satisfied, Dubbo will still only export MetadataService (V1).

@chickenlj
Copy link
Contributor

Well done. Generally looks good to me.

Copy link
Contributor

@FoghostCn FoghostCn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we implement the tri protocol in a non-idl way, so that our interface definition can be reused, and we only need to set the protocol to tri when using it. I don't know if this is feasible.

@@ -96,6 +96,8 @@ public class ServiceInstanceMetadataUtils {
*/
public static final String METADATA_STORAGE_TYPE_PROPERTY_NAME = "dubbo.metadata.storage-type";

public static final String METADATA_SERVICE_VERSION_NAME = "dubbo.metadata.service-version";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use as short a name as possible, for example, meta-v.

Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@EarthChen EarthChen requested a review from icodening June 20, 2024 06:18
Copy link

sonarcloud bot commented Jun 23, 2024

@chickenlj chickenlj merged commit ca1ae1f into apache:3.3 Jun 25, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants