-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New metadata service #14210
New metadata service #14210
Conversation
…nto 3.3-new-metadata-service-stub
Well done. Generally looks good to me. |
…nto 3.3-new-metadata-service-stub
…nto 3.3-new-metadata-service-stub
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we implement the tri protocol in a non-idl way, so that our interface definition can be reused, and we only need to set the protocol to tri when using it. I don't know if this is feasible.
@@ -96,6 +96,8 @@ public class ServiceInstanceMetadataUtils { | |||
*/ | |||
public static final String METADATA_STORAGE_TYPE_PROPERTY_NAME = "dubbo.metadata.storage-type"; | |||
|
|||
public static final String METADATA_SERVICE_VERSION_NAME = "dubbo.metadata.service-version"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use as short a name as possible, for example, meta-v
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
dubbo-metadata/dubbo-metadata-api/src/main/proto/metadata_service_v2.proto
Show resolved
Hide resolved
|
Purpose of the Change
This PR introduces a new version of
MetadataService
(V2) based on Protobuf, which provides better compatibility with dubbo-go.See #13584
Brief Changelog
To use
MetadataServiceV2
, the application must meet the following requirements:metadataServiceProtocol
is configured as 'tri', or at least one service is using the triple protocol.Currently,
MetadataServiceV2
will automatically export along withMetadataService
(V1, on the same port) if the above requirements are satisfied. IfonlyUseMetadataV2
is set totrue
, onlyMetadataServiceV2
will be exported. If the above requirements are not satisfied, Dubbo will still only exportMetadataService
(V1).