-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature][3.3] Triple rest jaxrs ParamConverter support #14148
Conversation
@oxsean PTAL |
@fanlobu Is it ready for review? |
I think it is ok, I did some simple tests in local |
.../src/main/java/org/apache/dubbo/rpc/protocol/tri/rest/support/jaxrs/JaxrsParamConverter.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need unit test for this.
.../src/main/java/org/apache/dubbo/rpc/protocol/tri/rest/support/jaxrs/JaxrsParamConverter.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/dubbo/rpc/protocol/tri/rest/support/jaxrs/ParamConverterFactory.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/dubbo/rpc/protocol/tri/rest/support/jaxrs/ParamConverterFactory.java
Outdated
Show resolved
Hide resolved
...xrs/src/main/java/org/apache/dubbo/rpc/protocol/tri/rest/support/jaxrs/JaxrsRestToolKit.java
Outdated
Show resolved
Hide resolved
@fanlobu please resolve error-code-inspector error first, You need log with error code |
LGTM. |
Thanks for all the suggestions for my code changes, I've done all the changes, but CICDtest runs failed, I checked the logs but didn't find a solution. Does this test run fail have anything to do with my commit ? |
Looks like a timeout, you can make a small change, like an empty line or a comment, to trigger the CI again. |
|
What is the purpose of the change
Triple rest jaxrs ParamConverter support,related: #14037
Brief changelog
Verifying this change
Checklist