-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(3.2): Triple Reactor OneToMany Handler null pointer fix and DubboFilter support #14125
fix(3.2): Triple Reactor OneToMany Handler null pointer fix and DubboFilter support #14125
Conversation
@caoyanan666 Please fix the conflicts |
# Conflicts: # dubbo-plugin/dubbo-reactive/src/main/java/org/apache/dubbo/reactive/calls/ReactorServerCalls.java
|
https://github.com/apache/dubbo/actions/runs/9011837780/job/24760283649?pr=14125 |
这个原因有可能是端口起在了20881上,具体为啥20880没启动成功,日志里面定位不到 |
好像是3.2所有的ci都卡在这了, https://github.com/apache/dubbo/actions/runs/9011299521/job/24758927418?pr=14166 ,坐等修复... |
Try to fix it in apache/dubbo-integration-cases#25 |
You can ignore it |
@AlbumenJ PTAL |
@@ -53,7 +53,7 @@ public void subscribe(final CallStreamObserver<T> downstream) { | |||
if (downstream == null) { | |||
throw new NullPointerException(); | |||
} | |||
if (this.downstream == null && SUBSCRIBED.compareAndSet(false, true)) { | |||
if (SUBSCRIBED.compareAndSet(false, true)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please help optimize the code style. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran spotless:apply again. Do you mean the hard coding of true and false?
/** | ||
* The Subscriber in server to passing the data produced by user publisher to responseStream. | ||
*/ | ||
public class ServerTripleReactorSubscriber<T> extends AbstractTripleReactorSubscriber<T> { | ||
|
||
private final List<T> collectedData = new ArrayList<>(); | ||
private final CompletableFuture<List<T>> completableFuture = new CompletableFuture<>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Make naming
completableFuture
more meaningful. - Why is List type? Is combined future?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What is the purpose of the change
Brief changelog
Verifying this change
Checklist