-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task #13958 Move Rest Protocol to SPI Extensions #14061
Conversation
delete the conflicts(rest related)
There are three things to note:
What should I do about these problems? |
After discussion, it is appropriate to move these three tests to |
@wcy666103 Too many things are included in one single pull request, better only include one thing each time. |
|
please resolve conflicts |
# Conflicts: # dubbo-remoting/dubbo-remoting-http/src/main/java/org/apache/dubbo/remoting/http/config/HttpClientConfig.java # dubbo-remoting/dubbo-remoting-http/src/main/java/org/apache/dubbo/remoting/http/restclient/OKHttpRestClient.java
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@AlbumenJ dubbo-samples-test-13787 test failed ,help check |
What is the purpose of the change
Brief changelog
Verifying this change
Checklist