Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix triple stub calling grpc server fail #14012

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

icodening
Copy link
Contributor

What is the purpose of the change

fix #13980

Brief changelog

modify interface name when NATIVE_STUB proxy

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

Copy link

sonarcloud bot commented Mar 30, 2024

@icodening icodening requested a review from AlbumenJ March 30, 2024 15:25
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.40%. Comparing base (00812ce) to head (4845889).

Additional details and impacted files
@@            Coverage Diff             @@
##              3.2   #14012      +/-   ##
==========================================
- Coverage   70.43%   70.40%   -0.03%     
==========================================
  Files        1607     1607              
  Lines       70074    70075       +1     
  Branches    10100    10100              
==========================================
- Hits        49356    49336      -20     
- Misses      16080    16095      +15     
- Partials     4638     4644       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EarthChen PTAL

Copy link
Member

@EarthChen EarthChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazyStar00
Copy link
Contributor

It has been tested and indeed solved the problem #13980

@EarthChen EarthChen merged commit ec44304 into apache:3.2 Apr 1, 2024
19 checks passed
Will-well pushed a commit to Will-well/dubbo that referenced this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] dubbo interacts with native grpc java_package is unavailable
5 participants