-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Sonar issue s2293 The diamond operator ('<>') should be used #14005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes code formatting
Fix spotless issue
Fix spotless issue
Fix spotless issue
Fix spotless issue
Fix spotless issue
Fix spotless issue
Fix spotless issue
Fix spotless issue
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.2 #14005 +/- ##
==========================================
- Coverage 70.42% 70.41% -0.01%
==========================================
Files 1607 1607
Lines 70075 70074 -1
Branches 10100 10100
==========================================
- Hits 49348 49342 -6
Misses 16087 16087
- Partials 4640 4645 +5 ☔ View full report in Codecov by Sentry. |
AlbumenJ
approved these changes
Mar 29, 2024
Will-well
pushed a commit
to Will-well/dubbo
that referenced
this pull request
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We propose the fix to violation s2293 "The diamond operator ('<>') should be used" identified by SonarQube.
Java uses angular brackets (< and >) to provide a specific type (the "type argument") to a generic type. For instance, List is a generic type, so a list containing strings can be declared with List.
Prior to Java 7, the type argument had to be provided explicitly for every occurrence where generics were used. This often caused redundancy, as the type argument would have to be provided both when a field is declared and initialized.
Java 7 introduced the diamond operator (<>) to reduce the code’s verbosity of generics code. The type argument between the angular brackets should be omitted if the compiler can infer it. For instance, instead of having to declare a List's type in both its declaration and its constructor, you can now simplify the constructor declaration with <>, and the compiler will infer the type.
This patch has been automatically produced by our java code remediation solution, available free of charge for all open source projects (https://www.indepth.fr/).
We believe that this PR can improve the quality of the Guava project code to a certain extent. Your feedback will also be very useful for us to know if our solution produces quality code or if we need to improve the way it works.
Thank you for your feedback.