-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For HTTP/1 unary mode, use Content-Length instead of chunk #13979
For HTTP/1 unary mode, use Content-Length instead of chunk #13979
Conversation
@oxsean PTAL |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.3 #13979 +/- ##
==========================================
- Coverage 38.55% 38.54% -0.01%
==========================================
Files 1895 1896 +1
Lines 79272 79302 +30
Branches 11528 11527 -1
==========================================
+ Hits 30560 30565 +5
- Misses 44439 44466 +27
+ Partials 4273 4271 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For HTTP/2 unary, should we fix it?
Maybe we don't need to fix it, refer to this link: https://stackoverflow.com/questions/77520309/why-is-content-length-header-not-sent-over-http-3. |
@AlbumenJ @finefuture I think END_STREAM flag is enough, because END_STREAM flag is mandatory. |
@oxsean PTAL |
@AlbumenJ LGTM |
|
What is the purpose of the change
Refer: #13933
For example:
![image](https://private-user-images.githubusercontent.com/18413695/315909829-41435cce-fcb8-4789-ba35-02edba459fe0.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQzMDMyODEsIm5iZiI6MTcyNDMwMjk4MSwicGF0aCI6Ii8xODQxMzY5NS8zMTU5MDk4MjktNDE0MzVjY2UtZmNiOC00Nzg5LWJhMzUtMDJlZGJhNDU5ZmUwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODIyVDA1MDMwMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWRlMWFkNGMwNjM3MzMyOTZhNmE5NTI5OGMwNGQ2ZDhiMjZmOWJlZmQ0ZWNiMmJkMzYwMjRlYmU0ZmE5NzI5MjcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.2GexWi_fW_1mU8KQT5ft33VXi1BAT2njrGFcFxih3r4)
Brief changelog
Verifying this change
Checklist