-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the problem of multiple namespaces in MetadataReport #13971
Merged
Merged
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
e65ca11
Fix the problem of multiple namespaces in MetadataReport
finefuture 1905f93
Merge branch '3.2' into 3.2-fix-namespace
finefuture ffd84c8
Merge branch '3.2' into 3.2-fix-namespace
finefuture 4eaf69f
refine
finefuture b8a5e36
Remove registry config setting
finefuture 422dffc
Merge branch '3.2' into 3.2-fix-namespace
finefuture 00b0510
Add some unit tests
finefuture 76a0283
Merge branch '3.2' into 3.2-fix-namespace
finefuture 7584574
Merge branch 'apache:3.2' into 3.2-fix-namespace
finefuture 0d21a45
Revert getId
finefuture ecaadbd
Merge branch '3.2' into 3.2-fix-namespace
finefuture 63a9160
Fix cache key
finefuture 6d1ab25
Merge branch '3.2' into 3.2-fix-namespace
finefuture e0966e8
Merge branch '3.2' into 3.2-fix-namespace
finefuture 7a7baca
Merge branch '3.2' into 3.2-fix-namespace
finefuture 434efaf
Merge branch '3.2' into 3.2-fix-namespace
finefuture 3cd9a9f
Merge branch '3.2' into 3.2-fix-namespace
finefuture d22af05
Merge branch '3.2' into 3.2-fix-namespace
finefuture File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you describe the difference between the new url and the old url?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about making it a public util method to make calling it in other places easier? like here https://github.com/apache/dubbo/pull/13971/files#diff-17a0f234d88728ebc6f37959d84276704ca16846cd10cd0743616a8689949eabR33
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a new method for extra parameters.
![image](https://private-user-images.githubusercontent.com/18413695/320279624-c587c5bf-6541-4b5d-8c58-fa20298bfc24.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYxNTM5NTIsIm5iZiI6MTcyNjE1MzY1MiwicGF0aCI6Ii8xODQxMzY5NS8zMjAyNzk2MjQtYzU4N2M1YmYtNjU0MS00YjVkLThjNTgtZmEyMDI5OGJmYzI0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTEyVDE1MDczMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTU0NjA5ZDJjOGNhMTBjMDU1NWFlOWJjM2Q2MDNjNjJmNzM2MGFkOWVjNmE1YTQ1YzQxNjhlN2VkMTAwODE0NTQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.UceRcSvf3xMv1-MUPdGa84pUsWutHockuO_1ixVGa2w)