Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:add condition to match serviceKey. #13869

Merged
merged 3 commits into from
Mar 12, 2024

Conversation

kazetyan
Copy link
Contributor

@kazetyan kazetyan commented Mar 8, 2024

What is the purpose of the change

fix #13772
add condition to match serviceKey.

Brief changelog

Verifying this change

see org.apache.dubbo.qos.command.impl.ChangeTelnetTest#testChangeServiceKey
and org.apache.dubbo.qos.command.impl.CountTelnetTest#testCountByServiceKey
image

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@AlbumenJ
Copy link
Member

image
Please fix failed test cases.

Copy link

sonarcloud bot commented Mar 11, 2024

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.37%. Comparing base (d50adb7) to head (993ee7f).

Additional details and impacted files
@@            Coverage Diff             @@
##              3.2   #13869      +/-   ##
==========================================
- Coverage   70.38%   70.37%   -0.01%     
==========================================
  Files        1607     1607              
  Lines       70070    70072       +2     
  Branches    10098    10100       +2     
==========================================
- Hits        49316    49311       -5     
- Misses      16131    16133       +2     
- Partials     4623     4628       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kazetyan
Copy link
Contributor Author

@AlbumenJ fixed,PTAL

@AlbumenJ AlbumenJ merged commit 0553d70 into apache:3.2 Mar 12, 2024
19 checks passed
@AlbumenJ AlbumenJ modified the milestone: 3.2.12 Mar 12, 2024
@kazetyan kazetyan deleted the fix-match-servicekey branch March 12, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Usage question of QoS invoke
3 participants