Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URL issue #13807

Merged
merged 3 commits into from
Mar 1, 2024
Merged

Fix URL issue #13807

merged 3 commits into from
Mar 1, 2024

Conversation

namelessssssssssss
Copy link
Contributor

What is the purpose of the change

URL#addAttributes used wrong attributes

//old
public URL addAttributes(Map<String, Object> attributes) {
        if (attributes != null) {
            attributes.putAll(attributes);
     return this;
}
//new
 public URL addAttributes(Map<String, Object> attributeMap) {
        if (attributeMap != null) {
            attributes.putAll(attributeMap);
        }
        return this;
}

Brief changelog

  • fix issues in URL#addAttributes
  • code style improvement

@codecov-commenter
Copy link

codecov-commenter commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.37%. Comparing base (d53d8e5) to head (441a73e).

Additional details and impacted files
@@            Coverage Diff             @@
##              3.2   #13807      +/-   ##
==========================================
- Coverage   70.38%   70.37%   -0.02%     
==========================================
  Files        1607     1607              
  Lines       70070    70070              
  Branches    10101    10098       -3     
==========================================
- Hits        49322    49312      -10     
- Misses      16115    16122       +7     
- Partials     4633     4636       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlbumenJ
Copy link
Member

Are there any references of addAttributes in Dubbo?

@namelessssssssssss
Copy link
Contributor Author

Are there any references of addAttributes in Dubbo?

Only in test cases

Copy link

sonarcloud bot commented Feb 29, 2024

@AlbumenJ AlbumenJ merged commit 860ad02 into apache:3.2 Mar 1, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants